Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: No panic if filter condition on indexed field is empty #2929

Merged
merged 1 commit into from
Aug 20, 2024

Check if filter condition is empty

81dcca6
Select commit
Loading
Failed to load commit list.
Merged

fix: No panic if filter condition on indexed field is empty #2929

Check if filter condition is empty
81dcca6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 19, 2024 in 1s

79.47% (-0.03%) compared to defb37a

View this Pull Request on Codecov

79.47% (-0.03%) compared to defb37a

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.47%. Comparing base (defb37a) to head (81dcca6).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2929      +/-   ##
===========================================
- Coverage    79.51%   79.47%   -0.03%     
===========================================
  Files          325      325              
  Lines        24778    24781       +3     
===========================================
- Hits         19700    19694       -6     
- Misses        3669     3675       +6     
- Partials      1409     1412       +3     
Files Coverage Δ
internal/db/fetcher/indexer.go 85.71% <100.00%> (+2.83%) ⬆️
internal/db/fetcher/indexer_iterators.go 80.79% <100.00%> (+0.10%) ⬆️

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update defb37a...81dcca6. Read the comment docs.