chore: Make Cid versions consistent #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code is dead, and untested - consider removal (is half used by a single unit which only counts the keys, but doesn't assert their values)
AndrewSisley
added
area/crdt
AndrewSisley
force-pushed
the
sisley/chore/I49-investigate-cid-usage
branch
from
44e0dd9
to
36b5856
Compare
jsimnz
approved these changes
Nov 24, 2021
|
Nice, will rename the commit and then merge RE: sidenote - definitely prefer dripping stuff in as opposed to the hassle/risk of doing it all at once (although it doesn't play as nicely with squashing commits on merge sadly) |
AndrewSisley
force-pushed
the
sisley/chore/I49-investigate-cid-usage
branch
from
36b5856
to
c909037
Compare
Closed
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
* Rename test file to go runs tests * Remove commented out code * Remove unused property * Return V0 Cids from blockstore.AllKeysChan Code is dead, and untested - consider removal (is half used by a single unit which only counts the keys, but doesn't assert their values) * Use v1 Cids throughout the codebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #49
Review contains some small tweaks/fixes, followed by a proposed update to modifiy all our non-dockey Cids to v1 (from v0). Dockeys are already using v1 Cids (I think).
This will impact existing databases considerably and doubt we can rely on an existing migrations (such as when updating badger versions). I do not know if we need to actively do anything for this, or if our current users are happy to just nuke and rebuild their databases - please let me know if more is required here.
To do: