-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Strip DSKey prefixes and simplify NewDataStoreKey #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredcarle
added
bug
Something isn't working
action/no-benchmark
Skips the action that runs the benchmark.
labels
Nov 16, 2022
Codecov Report
@@ Coverage Diff @@
## develop #944 +/- ##
===========================================
+ Coverage 60.29% 60.30% +0.01%
===========================================
Files 164 164
Lines 17700 17712 +12
===========================================
+ Hits 10672 10682 +10
- Misses 6081 6082 +1
- Partials 947 948 +1
|
AndrewSisley
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks for fixing this :)
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…rk#944) Relevant issue(s) Resolves sourcenetwork#943 Resolves sourcenetwork#799 Description The PR returns NewDataStoreKey to its simplest form of element indexing requiring the provided key string to be either 3 (Object Marker) or 4 elements. To accomplish this we made sure that the return datastorekey strings were stripped of prefixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #943
Resolves #799
Description
The PR returns NewDataStoreKey to its simplest form of element indexing requiring the provided key string to be either 3 (Object Marker) or 4 elements. To accomplish this we made sure that the return datastorekey strings were stripped of prefixes.
Tasks
How has this been tested?
make test
Specify the platform(s) on which this was tested: