Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add new setup for testing explain functionality #949

Merged
merged 7 commits into from
Nov 27, 2022

Commits on Nov 24, 2022

  1. pr: Makefile - Add a rule to only build the tests

    I found myself wanting to quickly see if my changes to the test files
    still compiles the tests. Hence this rule.
    shahzadlone committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    4a83513 View commit details
    Browse the repository at this point in the history
  2. pr: Move - All explain tests under one folder

    Also fix all the tests whose keys and other attributes changed due to
    having a different schema (all mutation explain tests were moved to use the
    previous schema used by query explain tests.).
    shahzadlone committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    5dec3a0 View commit details
    Browse the repository at this point in the history
  3. pr: Prepare - Make testing utils package reusable

    This commit makes some changes that would let us reuse some code that
    will also be needed for the new explain setup. As the explain testing
    setup will build on top of this, I wanted this to be a separate commit.
    Hopefully not too bad to review.
    shahzadlone committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    22b2c2b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    04c77f2 View commit details
    Browse the repository at this point in the history
  5. temp(drop): Example - Add examples of new setup

    Example to see the old and new testing sie by side.
    
    Note: This commit will be dropped before merge, it is there only to
    help visualize the usage of the new explain test setup.
    shahzadlone committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    1822201 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2022

  1. pr: Adhere - Apply the code review suggestions.

    For example:
    - Fail if given an empty request for a non-transactional test.
    
    One additional thing I crammed into this commit was to handle a list of
    map to also be copied while copying a map.
    shahzadlone committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    eb51055 View commit details
    Browse the repository at this point in the history
  2. pr: Fix - Traverse map for targets in sorted order

    Also changes the example tests to ensure the order works, and
    sort the keys in sorted order of map (for more visual clarity).
    shahzadlone committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    f0dcc39 View commit details
    Browse the repository at this point in the history