ci: Run Containerfile, Builder Containerfile #951

orpheuslummis · 2022-11-24T15:49:07Z

Relevant issue(s)

Resolves #950

Description

Fixes the 'runner' container file
introduces 'builder' container file
Use Containerfile terminology which goes beyond Docker.

Tasks

I made sure the code is well commented, particularly hard-to-understand areas.
I made sure the repository-held documentation is changed accordingly.
I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

Specify the platform(s) on which this was tested:

Debian Linux
MacOS

source-devs · 2022-11-24T15:57:06Z

Benchmark Results

Summary

113 Benchmarks successfully compared.
73 Benchmarks were ✅ Better.
40 Benchmarks were ❌ Worse .
0 Benchmarks were ✨ Unchanged.

✅ See Better Results...

	time/op		delta
_Collection_UserSimple_Create_Sync_0_10-4	12.6ms ± 0%	10.7ms ± 0%	−15.31%	(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4	118ms ± 0%	103ms ± 0%	−12.86%	(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-4	46.6ms ± 0%	46.2ms ± 0%	−0.84%	(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4	465ms ± 0%	459ms ± 0%	−1.34%	(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-4	4.72s ± 0%	4.68s ± 0%	−0.68%	(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4	380µs ± 0%	364µs ± 0%	−4.04%	(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-4	3.84ms ± 0%	3.69ms ± 0%	−3.87%	(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-4	40.4ms ± 0%	39.1ms ± 0%	−3.37%	(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4	410µs ± 0%	366µs ± 0%	−10.84%	(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-4	5.36ms ± 0%	3.82ms ± 0%	−28.68%	(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4	279µs ± 0%	261µs ± 0%	−6.42%	(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4	264µs ± 0%	260µs ± 0%	−1.48%	(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-4	1.90ms ± 0%	1.87ms ± 0%	−1.33%	(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-4	1.60ms ± 0%	1.18ms ± 0%	−26.67%	(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-4	11.8ms ± 0%	9.8ms ± 0%	−17.40%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4	573µs ± 0%	505µs ± 0%	−11.88%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-4	1.70ms ± 0%	1.41ms ± 0%	−17.07%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-4	10.0ms ± 0%	9.9ms ± 0%	−1.50%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4	463µs ± 0%	450µs ± 0%	−2.73%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4	600µs ± 0%	484µs ± 0%	−19.31%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4	1.06ms ± 0%	0.73ms ± 0%	−31.73%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4	893µs ± 0%	725µs ± 0%	−18.77%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4	552µs ± 0%	453µs ± 0%	−17.86%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-4	1.64ms ± 0%	1.32ms ± 0%	−19.14%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-4	12.8ms ± 0%	10.6ms ± 0%	−16.89%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4	484µs ± 0%	341µs ± 0%	−29.44%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4	435µs ± 0%	313µs ± 0%	−28.07%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-4	16.2µs ± 0%	15.0µs ± 0%	−7.61%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-4	16.8µs ± 0%	16.4µs ± 0%	−2.27%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-4	21.6µs ± 0%	20.5µs ± 0%	−5.33%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4	158µs ± 0%	140µs ± 0%	−11.17%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4	156µs ± 0%	153µs ± 0%	−2.11%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4	177µs ± 0%	148µs ± 0%	−16.73%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4	192µs ± 0%	165µs ± 0%	−14.05%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4	232µs ± 0%	200µs ± 0%	−13.66%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-4	17.7µs ± 0%	15.1µs ± 0%	−14.74%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-4	17.1µs ± 0%	15.9µs ± 0%	−6.61%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-4	18.7µs ± 0%	16.7µs ± 0%	−10.82%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-4	23.8µs ± 0%	18.8µs ± 0%	−20.90%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4	150µs ± 0%	145µs ± 0%	−3.26%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4	156µs ± 0%	149µs ± 0%	−4.52%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4	171µs ± 0%	153µs ± 0%	−10.45%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-4	61.1µs ± 0%	57.8µs ± 0%	−5.46%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-4	72.1µs ± 0%	70.2µs ± 0%	−2.58%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4	391µs ± 0%	390µs ± 0%	−0.26%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4	395µs ± 0%	373µs ± 0%	−5.63%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4	406µs ± 0%	395µs ± 0%	−2.81%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4	458µs ± 0%	441µs ± 0%	−3.72%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4	518µs ± 0%	509µs ± 0%	−1.80%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-4	62.2µs ± 0%	56.1µs ± 0%	−9.81%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4	405µs ± 0%	389µs ± 0%	−3.94%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4	135µs ± 0%	133µs ± 0%	−1.69%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4	138µs ± 0%	136µs ± 0%	−1.65%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-4	1.35ms ± 0%	1.33ms ± 0%	−1.25%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4	135µs ± 0%	122µs ± 0%	−9.41%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4	131µs ± 0%	124µs ± 0%	−5.05%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4	135µs ± 0%	126µs ± 0%	−6.39%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-4	1.27ms ± 0%	1.21ms ± 0%	−4.65%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-4	1.67ms ± 0%	1.39ms ± 0%	−16.63%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-4	10.0µs ± 0%	8.6µs ± 0%	−13.76%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-4	10.0µs ± 0%	9.5µs ± 0%	−4.56%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-4	11.9µs ± 0%	10.4µs ± 0%	−12.51%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-4	12.8µs ± 0%	12.2µs ± 0%	−4.90%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-4	17.5µs ± 0%	16.2µs ± 0%	−7.61%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-4	110µs ± 0%	108µs ± 0%	−2.13%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-4	117µs ± 0%	97µs ± 0%	−16.83%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4	128µs ± 0%	126µs ± 0%	−1.99%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4	156µs ± 0%	129µs ± 0%	−17.40%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4	127µs ± 0%	127µs ± 0%	−0.07%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-4	1.31ms ± 0%	1.19ms ± 0%	−9.57%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-4	1.30ms ± 0%	1.25ms ± 0%	−3.91%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-4	1.47ms ± 0%	1.26ms ± 0%	−13.86%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-4	1.52ms ± 0%	1.30ms ± 0%	−14.50%	(p=1.000 n=1+1)

❌ See Worse Results...

	time/op		delta
_Collection_UserSimple_CreateMany_Sync_0_100-4	252ms ± 0%	256ms ± 0%	+1.77%	(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-4	1.05s ± 0%	1.06s ± 0%	+0.29%	(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-4	1.86ms ± 0%	1.88ms ± 0%	+1.08%	(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-4	24.9ms ± 0%	28.6ms ± 0%	+14.83%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4	469µs ± 0%	472µs ± 0%	+0.71%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4	704µs ± 0%	718µs ± 0%	+2.03%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4	308µs ± 0%	311µs ± 0%	+0.97%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-4	15.3µs ± 0%	16.8µs ± 0%	+10.17%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-4	24.4µs ± 0%	24.8µs ± 0%	+1.74%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4	200µs ± 0%	230µs ± 0%	+14.91%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4	222µs ± 0%	239µs ± 0%	+8.04%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-4	50.1µs ± 0%	52.8µs ± 0%	+5.43%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-4	48.9µs ± 0%	52.2µs ± 0%	+6.70%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-4	54.3µs ± 0%	56.6µs ± 0%	+4.21%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-4	50.8µs ± 0%	52.3µs ± 0%	+2.85%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-4	47.3µs ± 0%	48.4µs ± 0%	+2.39%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-4	51.8µs ± 0%	57.4µs ± 0%	+10.81%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-4	68.3µs ± 0%	68.6µs ± 0%	+0.41%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4	400µs ± 0%	414µs ± 0%	+3.37%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4	407µs ± 0%	445µs ± 0%	+9.32%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4	448µs ± 0%	452µs ± 0%	+0.78%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4	532µs ± 0%	569µs ± 0%	+7.11%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4	126µs ± 0%	127µs ± 0%	+0.44%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4	135µs ± 0%	146µs ± 0%	+8.49%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4	156µs ± 0%	171µs ± 0%	+10.07%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-4	1.39ms ± 0%	1.43ms ± 0%	+2.39%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-4	1.24ms ± 0%	1.46ms ± 0%	+17.04%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-4	1.26ms ± 0%	1.39ms ± 0%	+9.72%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-4	1.56ms ± 0%	1.71ms ± 0%	+9.24%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4	123µs ± 0%	128µs ± 0%	+4.11%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4	135µs ± 0%	142µs ± 0%	+5.62%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-4	1.14ms ± 0%	1.18ms ± 0%	+2.94%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-4	1.24ms ± 0%	1.32ms ± 0%	+5.96%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-4	1.22ms ± 0%	1.29ms ± 0%	+5.59%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4	105µs ± 0%	109µs ± 0%	+4.09%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4	117µs ± 0%	146µs ± 0%	+24.26%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4	177µs ± 0%	182µs ± 0%	+3.04%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4	126µs ± 0%	129µs ± 0%	+2.05%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4	129µs ± 0%	130µs ± 0%	+0.05%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-4	1.19ms ± 0%	1.23ms ± 0%	+3.41%	(p=1.000 n=1+1)

✨ See Unchanged Results...

	time/op		delta

🐋 See Full Results...

	develop.txt	current.txt
	time/op		delta
pkg:collection goos:linux goarch:amd64
_Collection_UserSimple_CreateMany_Sync_0_10-4	11.3ms ± 0%	15.4ms ± 0%	+36.40%	(p=1.000 n=1+1)
_Collection_UserSimple_CreateMany_Sync_0_100-4	252ms ± 0%	256ms ± 0%	+1.77%	(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-4	12.6ms ± 0%	10.7ms ± 0%	−15.31%	(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4	118ms ± 0%	103ms ± 0%	−12.86%	(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-4	1.05s ± 0%	1.06s ± 0%	+0.29%	(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-4	46.6ms ± 0%	46.2ms ± 0%	−0.84%	(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4	465ms ± 0%	459ms ± 0%	−1.34%	(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-4	4.72s ± 0%	4.68s ± 0%	−0.68%	(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4	380µs ± 0%	364µs ± 0%	−4.04%	(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-4	3.84ms ± 0%	3.69ms ± 0%	−3.87%	(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-4	40.4ms ± 0%	39.1ms ± 0%	−3.37%	(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4	410µs ± 0%	366µs ± 0%	−10.84%	(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-4	5.36ms ± 0%	3.82ms ± 0%	−28.68%	(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4	279µs ± 0%	261µs ± 0%	−6.42%	(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-4	1.86ms ± 0%	1.88ms ± 0%	+1.08%	(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-4	24.9ms ± 0%	28.6ms ± 0%	+14.83%	(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4	264µs ± 0%	260µs ± 0%	−1.48%	(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-4	1.90ms ± 0%	1.87ms ± 0%	−1.33%	(p=1.000 n=1+1)
pkg:query/simple goos:linux goarch:amd64
_Query_UserSimple_Query_Sync_10-4	536µs ± 0%	378µs ± 0%	−29.49%	(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-4	1.60ms ± 0%	1.18ms ± 0%	−26.67%	(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-4	11.8ms ± 0%	9.8ms ± 0%	−17.40%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4	573µs ± 0%	505µs ± 0%	−11.88%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-4	1.70ms ± 0%	1.41ms ± 0%	−17.07%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-4	10.0ms ± 0%	9.9ms ± 0%	−1.50%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4	463µs ± 0%	450µs ± 0%	−2.73%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4	600µs ± 0%	484µs ± 0%	−19.31%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4	469µs ± 0%	472µs ± 0%	+0.71%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4	1.06ms ± 0%	0.73ms ± 0%	−31.73%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4	893µs ± 0%	725µs ± 0%	−18.77%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4	704µs ± 0%	718µs ± 0%	+2.03%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4	552µs ± 0%	453µs ± 0%	−17.86%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-4	1.64ms ± 0%	1.32ms ± 0%	−19.14%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-4	12.8ms ± 0%	10.6ms ± 0%	−16.89%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4	484µs ± 0%	341µs ± 0%	−29.44%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4	435µs ± 0%	313µs ± 0%	−28.07%	(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4	308µs ± 0%	311µs ± 0%	+0.97%	(p=1.000 n=1+1)
pkg:storage goos:linux goarch:amd64
_Storage_Simple_Read_Sync_1_10/ValueSize:0064-4	15.0µs ± 0%	14.5µs ± 0%	−3.30%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-4	16.2µs ± 0%	15.0µs ± 0%	−7.61%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-4	15.3µs ± 0%	16.8µs ± 0%	+10.17%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-4	16.8µs ± 0%	16.4µs ± 0%	−2.27%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-4	21.6µs ± 0%	20.5µs ± 0%	−5.33%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4	158µs ± 0%	140µs ± 0%	−11.17%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4	156µs ± 0%	153µs ± 0%	−2.11%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4	177µs ± 0%	148µs ± 0%	−16.73%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4	192µs ± 0%	165µs ± 0%	−14.05%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4	232µs ± 0%	200µs ± 0%	−13.66%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-4	17.7µs ± 0%	15.1µs ± 0%	−14.74%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-4	17.1µs ± 0%	15.9µs ± 0%	−6.61%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-4	18.7µs ± 0%	16.7µs ± 0%	−10.82%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-4	23.8µs ± 0%	18.8µs ± 0%	−20.90%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-4	24.4µs ± 0%	24.8µs ± 0%	+1.74%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4	150µs ± 0%	145µs ± 0%	−3.26%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4	156µs ± 0%	149µs ± 0%	−4.52%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4	171µs ± 0%	153µs ± 0%	−10.45%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4	200µs ± 0%	230µs ± 0%	+14.91%	(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4	222µs ± 0%	239µs ± 0%	+8.04%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-4	50.1µs ± 0%	52.8µs ± 0%	+5.43%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-4	48.9µs ± 0%	52.2µs ± 0%	+6.70%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-4	54.3µs ± 0%	56.6µs ± 0%	+4.21%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-4	61.1µs ± 0%	57.8µs ± 0%	−5.46%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-4	72.1µs ± 0%	70.2µs ± 0%	−2.58%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4	391µs ± 0%	390µs ± 0%	−0.26%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4	395µs ± 0%	373µs ± 0%	−5.63%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4	406µs ± 0%	395µs ± 0%	−2.81%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4	458µs ± 0%	441µs ± 0%	−3.72%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4	518µs ± 0%	509µs ± 0%	−1.80%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-4	50.8µs ± 0%	52.3µs ± 0%	+2.85%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-4	47.3µs ± 0%	48.4µs ± 0%	+2.39%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-4	51.8µs ± 0%	57.4µs ± 0%	+10.81%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-4	62.2µs ± 0%	56.1µs ± 0%	−9.81%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-4	68.3µs ± 0%	68.6µs ± 0%	+0.41%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4	405µs ± 0%	389µs ± 0%	−3.94%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4	400µs ± 0%	414µs ± 0%	+3.37%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4	407µs ± 0%	445µs ± 0%	+9.32%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4	448µs ± 0%	452µs ± 0%	+0.78%	(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4	532µs ± 0%	569µs ± 0%	+7.11%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4	126µs ± 0%	127µs ± 0%	+0.44%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4	135µs ± 0%	133µs ± 0%	−1.69%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4	138µs ± 0%	136µs ± 0%	−1.65%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4	135µs ± 0%	146µs ± 0%	+8.49%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4	156µs ± 0%	171µs ± 0%	+10.07%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-4	1.35ms ± 0%	1.33ms ± 0%	−1.25%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-4	1.39ms ± 0%	1.43ms ± 0%	+2.39%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-4	1.24ms ± 0%	1.46ms ± 0%	+17.04%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-4	1.26ms ± 0%	1.39ms ± 0%	+9.72%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-4	1.56ms ± 0%	1.71ms ± 0%	+9.24%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4	135µs ± 0%	122µs ± 0%	−9.41%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4	123µs ± 0%	128µs ± 0%	+4.11%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4	131µs ± 0%	124µs ± 0%	−5.05%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4	135µs ± 0%	126µs ± 0%	−6.39%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4	135µs ± 0%	142µs ± 0%	+5.62%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-4	1.14ms ± 0%	1.18ms ± 0%	+2.94%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-4	1.27ms ± 0%	1.21ms ± 0%	−4.65%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-4	1.24ms ± 0%	1.32ms ± 0%	+5.96%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-4	1.22ms ± 0%	1.29ms ± 0%	+5.59%	(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-4	1.67ms ± 0%	1.39ms ± 0%	−16.63%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-4	10.0µs ± 0%	8.6µs ± 0%	−13.76%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-4	10.0µs ± 0%	9.5µs ± 0%	−4.56%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-4	11.9µs ± 0%	10.4µs ± 0%	−12.51%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-4	12.8µs ± 0%	12.2µs ± 0%	−4.90%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-4	17.5µs ± 0%	16.2µs ± 0%	−7.61%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-4	110µs ± 0%	108µs ± 0%	−2.13%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-4	117µs ± 0%	97µs ± 0%	−16.83%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4	105µs ± 0%	109µs ± 0%	+4.09%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4	117µs ± 0%	146µs ± 0%	+24.26%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4	177µs ± 0%	182µs ± 0%	+3.04%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4	128µs ± 0%	126µs ± 0%	−1.99%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4	156µs ± 0%	129µs ± 0%	−17.40%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4	127µs ± 0%	127µs ± 0%	−0.07%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4	126µs ± 0%	129µs ± 0%	+2.05%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4	129µs ± 0%	130µs ± 0%	+0.05%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-4	1.31ms ± 0%	1.19ms ± 0%	−9.57%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-4	1.30ms ± 0%	1.25ms ± 0%	−3.91%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-4	1.19ms ± 0%	1.23ms ± 0%	+3.41%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-4	1.47ms ± 0%	1.26ms ± 0%	−13.86%	(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-4	1.52ms ± 0%	1.30ms ± 0%	−14.50%	(p=1.000 n=1+1)

Dockerfile

AndrewSisley · 2023-01-13T21:19:03Z

Just noting that I am happy with it, but am highly inexperienced with docker and would like you to wait for approval from someone who is not me before merging.

orpheuslummis · 2023-01-13T21:25:11Z

Just noting that I am happy with it, but am highly inexperienced with docker and would like you to wait for approval from someone who is not me before merging.

two criticism of this PR are :
A) there is no more 'Dockerfile' at root-level, making it slightly more non-obvious to find the containerfile and build it
B) the files use the new 'containerfile' nomenclature

my replies to this:
A) documentation in docs.source.network will make it easy. I think that's the kind of thing that shouldn't be on the README.
B) I describe the approach as forward looking because while Docker popularized the container, it is a single project and the world is moving on to a more generic container description with e.g. podman

fredcarle

A couple comments to discuss before approval :)

tools/defradb.dockerfile

fredcarle

LGTM

tools/defradb.containerfile

shahzadlone

LGTM (I didn't test the file, assuming you have ran it and tested it).

codecov · 2023-01-27T15:07:04Z

Codecov Report

Merging #951 (e551aea) into develop (825e749) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #951      +/-   ##
===========================================
+ Coverage    68.14%   68.16%   +0.01%     
===========================================
  Files          172      172              
  Lines        16246    16246              
===========================================
+ Hits         11071    11074       +3     
+ Misses        4245     4243       -2     
+ Partials       930      929       -1

Impacted Files	Coverage Δ
net/server.go	`58.23% <0.00%> (+1.14%)`	⬆️

shahzadlone · 2023-01-27T15:47:02Z

👀
Merge branch 'develop' into orpheus/chore/docker-works

orpheuslummis added the ci/build This is issue is about the build or CI system, and the administration of it. label Nov 24, 2022

orpheuslummis added this to the DefraDB v0.4 milestone Nov 24, 2022

orpheuslummis self-assigned this Nov 24, 2022

orpheuslummis added the action/no-benchmark Skips the action that runs the benchmark. label Nov 24, 2022

fredcarle reviewed Nov 24, 2022

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

orpheuslummis force-pushed the orpheus/chore/docker-works branch from 2f2bc6e to 2a77bd6 Compare January 6, 2023 21:01

orpheuslummis changed the title ~~chore: Improve robustness of Docker support~~ ci: Run Containerfile, Builder Containerfile Jan 6, 2023

orpheuslummis marked this pull request as ready for review January 7, 2023 22:01

jsimnz force-pushed the develop branch from a615303 to d87bae8 Compare January 8, 2023 00:16

Runner Containerfile, Builder Containerfile

66a3f91

orpheuslummis force-pushed the orpheus/chore/docker-works branch from 2a77bd6 to 66a3f91 Compare January 10, 2023 14:42

orpheuslummis requested a review from a team January 13, 2023 17:14

explanatory

df106b3

fredcarle reviewed Jan 19, 2023

View reviewed changes

tools/defradb.dockerfile Outdated Show resolved Hide resolved

tools/defradb.dockerfile Outdated Show resolved Hide resolved

orpheuslummis added 2 commits January 19, 2023 22:16

adjust

eeca1d3

rename to containerfile

7a7427b

fredcarle approved these changes Jan 20, 2023

View reviewed changes

shahzadlone reviewed Jan 20, 2023

View reviewed changes

tools/defradb.containerfile Show resolved Hide resolved

shahzadlone approved these changes Jan 20, 2023

View reviewed changes

jsimnz modified the milestones: DefraDB v0.4, DefraDB v0.5 Jan 20, 2023

Merge branch 'develop' into orpheus/chore/docker-works

dee7d6b

remove Dockerfile

e551aea

orpheuslummis merged commit e6ea3fa into develop Jan 27, 2023

orpheuslummis deleted the orpheus/chore/docker-works branch January 27, 2023 15:54

shahzadlone pushed a commit that referenced this pull request Apr 13, 2023

ci: Runner and Builder Containerfiles (#951)

fd54554

shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024

ci: Runner and Builder Containerfiles (sourcenetwork#951)

9b0c5ed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: Run Containerfile, Builder Containerfile #951

ci: Run Containerfile, Builder Containerfile #951

orpheuslummis commented Nov 24, 2022 •

edited

Loading

source-devs commented Nov 24, 2022

AndrewSisley commented Jan 13, 2023

orpheuslummis commented Jan 13, 2023

fredcarle left a comment

fredcarle left a comment

shahzadlone left a comment

codecov bot commented Jan 27, 2023 •

edited

Loading

shahzadlone commented Jan 27, 2023

ci: Run Containerfile, Builder Containerfile #951

ci: Run Containerfile, Builder Containerfile #951

Conversation

orpheuslummis commented Nov 24, 2022 • edited Loading

Relevant issue(s)

Description

Tasks

How has this been tested?

source-devs commented Nov 24, 2022

Benchmark Results

Summary

AndrewSisley commented Jan 13, 2023

orpheuslummis commented Jan 13, 2023

fredcarle left a comment

Choose a reason for hiding this comment

fredcarle left a comment

Choose a reason for hiding this comment

shahzadlone left a comment

Choose a reason for hiding this comment

codecov bot commented Jan 27, 2023 • edited Loading

Codecov Report

shahzadlone commented Jan 27, 2023

orpheuslummis commented Nov 24, 2022 •

edited

Loading

codecov bot commented Jan 27, 2023 •

edited

Loading