This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
feat: better server-side errors #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luizirber
commented
May 13, 2023
| @@ -29,4 +29,5 @@ tracing = "0.1" | |||
| tracing-subscriber = { version = "0.3", features = ["env-filter", "fmt", "json"] } | |||
|
|
|||
| [profile.release] | |||
| debug = true | |||
| debug = 1 | |||
| #lto = true # Enable link-time optimization | |||
There was a problem hiding this comment.
Disabling this for now because it has errors with rocksdb 0.18 (due to bz_internal_error duplication when linking). It is already fixed (more info) but need to update sourmash-bio/sourmash#2230 to use the newer rocksdb version.
luizirber
commented
May 13, 2023
Comment on lines
+66
to
+70
| environment: Some( | ||
| std::env::var("MASTIFF_ENVIRONMENT") | ||
| .unwrap_or("development".into()) | ||
| .into(), | ||
| ), |
There was a problem hiding this comment.
sentry uses debug/release to decide if it is development/production, but rocksdb is very slow in debug mode. Making it explicit here and defaulting to development unless MASTIFF_ENVIRONMENT is defined (which it is in production).
luizirber
force-pushed
the
lirber/better_errors_server
branch
from
a85cc74
to
70eb3a1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a request with an incompatible signature is sent there is no feedback to the requester about what went wrong. This PR implements one fix (by returning error
400and pointing whatkis expected), but can be extended in the future.