Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove sourmash compute in 5.0 #1286

Open
ctb opened this issue Jan 19, 2021 · 0 comments
Open

remove sourmash compute in 5.0 #1286

ctb opened this issue Jan 19, 2021 · 0 comments
Labels
5.0 issues to address for a 5.0 release
Milestone
5.0

Comments

@ctb
Copy link
Contributor

ctb commented Jan 19, 2021

per #1277
@ctb ctb added the 5.0 issues to address for a 5.0 release label Jan 19, 2021
@ctb ctb mentioned this issue Mar 11, 2021
Open
@ctb ctb mentioned this issue Apr 27, 2022
Open
@ctb ctb mentioned this issue Aug 17, 2023
Merged
@luizirber luizirber added this to the 5.0 milestone Dec 1, 2023
@ctb ctb mentioned this issue Apr 1, 2024
Merged
ctb added a commit that referenced this issue Apr 12, 2024
@ctb
MRG: prepare to remove sourmash compute for sourmash v5.0 (#3103)
f4e7205 
This PR refactors code to eliminate any internal dependencies on the
`compute` command or codebase, in preparation for removing `sourmash
compute` in v5.0, per
#1286.

Specifically, this PR:
* shifts common sketching code from `src/sourmash/command_compute.py` to
`src/sourmash/command_sketch.py`;
* refactors three tests that were still using `sourmash compute` to use
`sourmash sketch` instead.

No functionality is altered or adjusted in this PR; it's all just code
refactoring.

The next step for #1286 would maybe be adjust the code and the tests to
respect the `--v4` and `--v5` flags (as used in
#3072 /
#3074). The actual compute
code and command wouldn't be removed until after a 5.0 release, I think.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
5.0 issues to address for a 5.0 release
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
2 participants
@luizirber @ctb