Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gather against a mix of compatible and incompatible databases #1637

Closed
bluegenes opened this issue Jun 25, 2021 · 3 comments · Fixed by #2204
Closed

gather against a mix of compatible and incompatible databases #1637

bluegenes opened this issue Jun 25, 2021 · 3 comments · Fixed by #2204

Comments

@bluegenes
Copy link
Contributor

trying out #1590 (comment)

running a gather against all available databases (rather than only using databases with the right ksize/scaled)

I provided databases in for multiple ksizes (k7-11 protein) for a gather with k=11.

== This is sourmash version 4.1.3.dev16+g9dbd8b50. ==
== Please cite Brown and Irber (2016), doi:10.21105/joss.00027. ==

picking column 'name' of type 'identprefix' from 'output.protein-demo/sigs/protein/GCF_003143755.sig.csv'
loaded 1 distinct values into picklist.
WARNING: 1 values in picklist column 'name' were not distinct
selecting specified query k=11
loaded query: GCF_003143755... (k=11, protein)
no compatible signatures found in 'tests/test-data/databases/gtdb-rs202-reps.protein-k7.sbt.zip'

To enable compatible + incompatible databases for gather, we need to ignore incompatible databases as long as there are some compatible sigs in one of the provided databases.

@ctb
Copy link
Contributor

ctb commented Jun 25, 2021

right - as we've gotten more flexible with Index objects and so on, this has become more of a problem! My hot take is that we should be able to properly distinguish between -

  • at least one database exists, is loadable, and has relevant signatures (win!)
  • all the databases exist, all are loadable, but none have relevant signatures (fail with appropriate error message!)
  • one or more of the databases does not exist or is not loadable

Once upon a time this was more complicated b/c we were missing things like database compatibility checking, but with the newly enhanced™️ Index.select(...) stuff we can check for compatibility on load properly now.

@ctb
Copy link
Contributor

ctb commented Jun 26, 2021

see also #977

@ctb
Copy link
Contributor

ctb commented Mar 12, 2022

relevant: #1877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants