Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do about untrustworthy jaccard --> ANI estimates? #2004

Closed
bluegenes opened this issue Apr 27, 2022 · 1 comment · Fixed by #2011
Closed

What to do about untrustworthy jaccard --> ANI estimates? #2004

bluegenes opened this issue Apr 27, 2022 · 1 comment · Fixed by #2011

Comments

@bluegenes
Copy link
Contributor

When estimating ANI from Jaccard (only for scaled jaccard searches via sourmash search), we can run into cases where the error around the Jaccard estimate itself is too high for the Jaccard --> ANI conversion to be trustworthy.

We currently notify with a warning and store ani_untrustworthy in SearchResult.

WARNING: Error on Jaccard distance point estimate is too high (0.0010).

We could:

  1. add ani_untrustworthy column to Jaccard search output (though it is irrelevant for any other search/ANI)
  2. zero out the ANI estimate (""/None probably better than 0, as 0 is a valid ANI result)
@ctb
Copy link
Contributor

ctb commented Apr 28, 2022

I like zeroing it out. That, combined with the warning, should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants