[MRG] do not report untrusted jaccard ANI #2011
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2004
This PR modifies
jaccardANIResult
to only return an ANI value when the jaccard error does not exceed the recommended threshold. This means that ANI will not be returned to any jaccard ANI function (minhash, signature, compare, search, etc) if it is not trusted.I haven't enabled forcibly returning ANI in
minhash
orsignature
because I still return thedistance
(so if you really want the untrustworthy ANI anyway, you can just do1-distance
).