Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade development toolkit? #2421

Open
ctb opened this issue Dec 21, 2022 · 1 comment
Open

upgrade development toolkit? #2421

ctb opened this issue Dec 21, 2022 · 1 comment

Comments

@ctb
Copy link
Contributor

ctb commented Dec 21, 2022 •
edited
Loading

this article, Boring Python: code quality, has a lot of useful things in it - I found the following bits of advice particularly useful:

  • pre-commit hooks
  • package building checks

but there's lots of things we could just ...do.
@ctb
Copy link
Contributor Author

ctb commented Dec 28, 2022

re pre-commit hooks:

@luizirber -

I updated the pre-commit configs to match what is in https://github.com/tox-dev/tox/blob/main/.pre-commit-config.yaml, and...
226 files changed, 53948 insertions(+), 27719 deletions(-)
(and tests broke, need to be more careful when applying the changes 😂 )
145 files changed, 22372 insertions(+), 14196 deletions(-) without breaking tests =]
https://github.com/sourmash-bio/sourmash/compare/lirber/precommit_updates

@luizirber luizirber mentioned this issue Dec 31, 2022
Merged
luizirber added a commit that referenced this issue Feb 5, 2024
@luizirber
Pre-commit updates (#2427)
fee6292 
Ref #2421 
Fix #2908

Updates older pre-commit hooks (initial exp:
#680), mostly based (again)
on [tox
configs](https://github.com/tox-dev/tox/blob/main/.pre-commit-config.yaml)

Use ruff instead of pyupgrade/isort/black/flake8

This PR has a couple of commits: the first ones update configs, the last
one runs `tox -e fix_lint` to apply pre-commit. Mostly looking into
updating the first commits without breaking tests on the last commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctb