Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs: Threshold-bp and scaled relationship #2929

Closed
ccbaumler opened this issue Jan 16, 2024 · 2 comments · Fixed by #2930
Closed

Update docs: Threshold-bp and scaled relationship #2929

ccbaumler opened this issue Jan 16, 2024 · 2 comments · Fixed by #2930
Labels
doc documentation content or issues

Comments

@ccbaumler
Copy link
Contributor

Update the Faq after What scaled values should I use with sourmash? with "What threshold-bp should I use?".

This has been discussed in lab a few time over the last couple weeks and it may be relevant to others without direct lab access.
@ccbaumler ccbaumler added the doc documentation content or issues label Jan 16, 2024
@ctb
Copy link
Contributor

ctb commented Jan 16, 2024

notes from talking with colton in person -

3x the scaled value is a good default that limits false positives. But not yet published.

@ccbaumler ccbaumler mentioned this issue Jan 16, 2024
Merged
@ctb ctb closed this as completed in #2930 Jan 17, 2024
ctb pushed a commit that referenced this issue Jan 17, 2024
@ccbaumler
[MRG] Adding threshold-bp and scaled relationship to faqs (#2930)
ccb1d49 
This pull request is in response and fixes #2929 

I have adding a short dialogue about threshold-bp as referenced in other
documents as well as how I understand its function.
@ctb
Copy link
Contributor

ctb commented May 23, 2024

reference: #2360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc documentation content or issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] Adding threshold-bp and scaled relationship to faqs ccbaumler/sourmash
2 participants
@ctb @ccbaumler