Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create migrations from older index versions #488

Closed
luizirber opened this issue Jun 5, 2018 · 4 comments
Closed

Create migrations from older index versions #488

luizirber opened this issue Jun 5, 2018 · 4 comments
Labels

Comments

@luizirber
Copy link
Member

Create a migrate command (ou use convert?), and only load the latest DB version available (right now it tries to be clever and load any older version, which might take a long time depending on what needs to be set)

@ctb
Copy link
Contributor

ctb commented Jun 6, 2018 via email

@ctb
Copy link
Contributor

ctb commented Jun 7, 2018

Could this be as simple as iterating over all the leaves from an old SBT and constructing a new SBT as we go? Or is that too memory intensive/inefficient?

@luizirber
Copy link
Member Author

For migrating from old to new versions we don't need to rebuild the tree structure, mostly it's about fixing the JSON.

For converting from one storage to another we might need to touch the data (hidden dirs to TarStorage, for example)

Right now the tree structure is not terribly important, but at some point it might (thinking about clustering similar leaves under the same internal node, for example). Another issue with the 'iterating over all the leaves' is rebuilding all the internal nodes when it's not really necessary to do it.

@luizirber
Copy link
Member Author

Fixed by #494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants