Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] use install scripts from py-ipfs-http-client #1068

Merged
merged 2 commits into from
Jul 1, 2020
Merged

Conversation

luizirber
Copy link
Member

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #1068 into master will increase coverage by 9.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1068      +/-   ##
==========================================
+ Coverage   83.30%   92.55%   +9.24%     
==========================================
  Files          99       74      -25     
  Lines        8885     5590    -3295     
==========================================
- Hits         7402     5174    -2228     
+ Misses       1483      416    -1067     
Flag Coverage Δ
#rusttests ?
Impacted Files Coverage Δ
src/core/src/wasm.rs
src/core/src/index/search.rs
src/core/src/ffi/mod.rs
src/core/src/ffi/utils.rs
src/core/src/index/bigsi.rs
src/core/src/sketch/ukhs.rs
src/core/src/lib.rs
src/core/src/ffi/cmd/compute.rs
src/core/src/index/sbt/mod.rs
src/core/tests/minhash.rs
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40b5c35...ad755eb. Read the comment docs.

@luizirber
Copy link
Member Author

@ctb merge to fix the travis errors in #1059

@ctb ctb merged commit 80d975c into master Jul 1, 2020
@ctb ctb deleted the ci_ipfs_daemon branch July 1, 2020 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants