Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] add is_lineage_match, pop_to_rank, make_lineage to lca_utils #1081

Merged
merged 1 commit into from
Jul 4, 2020

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Jul 4, 2020

Add some useful functions to sourmash.lca.lca_utils. Right now they're mostly used in charcoal.

Fixes #458

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb ctb changed the title add is_lineage_match, pop_to_rank, make_lineage to lca_utils [MRG] add is_lineage_match, pop_to_rank, make_lineage to lca_utils Jul 4, 2020
@codecov
Copy link

codecov bot commented Jul 4, 2020

Codecov Report

Merging #1081 into master will increase coverage by 9.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1081      +/-   ##
==========================================
+ Coverage   83.77%   92.81%   +9.03%     
==========================================
  Files          99       74      -25     
  Lines        8958     5692    -3266     
==========================================
- Hits         7505     5283    -2222     
+ Misses       1453      409    -1044     
Flag Coverage Δ
#rusttests ?
Impacted Files Coverage Δ
sourmash/lca/lca_utils.py 92.80% <100.00%> (-3.04%) ⬇️
src/core/src/signature.rs
src/core/src/sketch/ukhs.rs
src/core/src/sketch/minhash.rs
src/core/src/wasm.rs
src/core/src/cmd.rs
src/core/src/errors.rs
src/core/src/ffi/utils.rs
src/core/src/ffi/cmd/compute.rs
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63a07db...83c0d49. Read the comment docs.

@ctb
Copy link
Contributor Author

ctb commented Jul 4, 2020

ready for review & merge @erikyoung85 @bluegenes

Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add some lineage manipulation functionality to lca_utils
2 participants