[MRG] Remove Python 2.7 support (& end Python 2 compatibility) #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## latest #1145 +/- ##
=========================================
Coverage ? 92.55%
=========================================
Files ? 73
Lines ? 5764
Branches ? 0
=========================================
Hits ? 5335
Misses ? 429
Partials ? 0 Continue to review full report at Codecov.
|
|
We can also check any place where |
|
(and remove 2.7 from CI) |
(this turns out to require some actual work :) |
ctb
changed the title
ctb
changed the title
ctb
changed the title
19 tasks
luizirber
reviewed
Aug 5, 2020
README.md
Outdated
| @@ -54,7 +54,7 @@ A quickstart tutorial [is available](https://sourmash.readthedocs.io/en/latest/t | |||
|
|
|||
| ### Requirements | |||
|
|
|||
| sourmash runs under both Python 2.7.x and Python 3.5+. The base | |||
| sourmash runs under Python 3.7 and later. The base | |||
luizirber
approved these changes
Aug 5, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all of the compatibility code and version checking necessary to support Python 2.7. 🎉
Fixes #1033
Fixes #318
Fixes #1043
make testDid it pass the tests?make coverageIs the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?