Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] update CI for latest branch name change #1150

Merged
merged 5 commits into from
Aug 6, 2020
Merged

[MRG] update CI for latest branch name change #1150

merged 5 commits into from
Aug 6, 2020

Conversation

luizirber
Copy link
Member

@luizirber luizirber commented Aug 6, 2020

Turns out the master->latest transition didn't touch CI. Oops!

TODO

  • schedule all checks to run on master every day for GitHub Actions (like it works in travis)
  • Update all places mentioning master (badges in README, binder links, docs...)

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

❗ No coverage uploaded for pull request base (latest@f4fac4b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             latest    #1150   +/-   ##
=========================================
  Coverage          ?   83.72%           
=========================================
  Files             ?       95           
  Lines             ?     9012           
  Branches          ?        0           
=========================================
  Hits              ?     7545           
  Misses            ?     1467           
  Partials          ?        0           
Flag Coverage Δ
#rusttests 67.86% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4fac4b...c6b5f9e. Read the comment docs.

@luizirber luizirber changed the title [WIP] update CI for latest branch name change [MRG] update CI for latest branch name change Aug 6, 2020
@luizirber
Copy link
Member Author

Ready for review and merge when checks are passing @ctb

@luizirber luizirber requested a review from ctb August 6, 2020 18:38
@ctb
Copy link
Contributor

ctb commented Aug 6, 2020

Looks good, overall. Question: do we want to point at stable URLs for documentation, notebooks, etc? I expect we'll keep stable up to date with the last release, in the future...

@luizirber
Copy link
Member Author

Looks good, overall. Question: do we want to point at stable URLs for documentation, notebooks, etc? I expect we'll keep stable up to date with the last release, in the future...

I thought stable was temporary until 4.0.0 is released, keep syncing branches will be annoying... Maybe turn stable into a tag, and add to the release notes to replace it on every stable release?

@luizirber luizirber merged commit 80d846e into latest Aug 6, 2020
@luizirber luizirber deleted the update_ci branch August 6, 2020 20:41
@luizirber luizirber mentioned this pull request Aug 6, 2020
@ctb ctb mentioned this pull request Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants