Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Remove TarStorage and replace usage with ZipStorage #1170

Merged
merged 2 commits into from
Aug 18, 2020

Conversation

luizirber
Copy link
Member

@luizirber luizirber commented Aug 14, 2020

Remove deprecation added in #1165

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@luizirber luizirber mentioned this pull request Aug 14, 2020
5 tasks
@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #1170 into latest will increase coverage by 9.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1170      +/-   ##
==========================================
+ Coverage   84.13%   93.16%   +9.02%     
==========================================
  Files          99       75      -24     
  Lines        9281     5944    -3337     
==========================================
- Hits         7809     5538    -2271     
+ Misses       1472      406    -1066     
Flag Coverage Δ
#rusttests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sourmash/sbt_storage.py 92.09% <ø> (-0.41%) ⬇️
sourmash/sbt.py 88.90% <100.00%> (ø)
src/core/src/index/linear.rs
src/core/src/errors.rs
src/core/src/ffi/minhash.rs
src/core/src/index/storage.rs
src/core/src/signature.rs
src/core/src/lib.rs
src/core/src/from.rs
src/core/src/ffi/utils.rs
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b261f5...6a9012a. Read the comment docs.

@luizirber luizirber changed the title [WIP] Remove TarStorage and replace usage with ZipStorage [MRG] Remove TarStorage and replace usage with ZipStorage Aug 17, 2020
@luizirber luizirber requested a review from ctb August 17, 2020 20:52
Copy link
Contributor

@ctb ctb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! assuming the tests pass :)

@luizirber luizirber merged commit e988d2c into latest Aug 18, 2020
@luizirber luizirber deleted the remove_tarstorage branch August 18, 2020 20:02
@ctb ctb mentioned this pull request Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants