Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] switch sbt.zip over to default SBT storage #1174

Merged
merged 8 commits into from
Nov 1, 2020
Merged

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Aug 17, 2020

Makes .sbt.zip the default output of sourmash index.

Fixes #972

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #1174 into latest will increase coverage by 9.55%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1174      +/-   ##
==========================================
+ Coverage   83.33%   92.89%   +9.55%     
==========================================
  Files         103       76      -27     
  Lines        9609     5992    -3617     
==========================================
- Hits         8008     5566    -2442     
+ Misses       1601      426    -1175     
Flag Coverage Δ
rusttests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sourmash/sbt.py 89.00% <95.65%> (+0.10%) ⬆️
sourmash/sbt_storage.py 91.52% <0.00%> (-0.57%) ⬇️
src/core/src/errors.rs
src/core/tests/test.rs
src/core/src/index/bigsi.rs
src/core/src/ffi/signature.rs
src/core/src/encodings.rs
src/core/tests/minhash.rs
src/core/src/ffi/mod.rs
src/core/src/index/mod.rs
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdc19d5...6b7aa39. Read the comment docs.

@luizirber
Copy link
Member

luizirber commented Nov 1, 2020

There is something going on with this PR. The IPFSStorage test is failing (and I think the correct fix is changing the tests to save to tree.sbt.json, instead of just tree, which gets converted to tree.sbt.zip) , but... it is taking more than 3x as long to run tests. That's... not acceptable =] (false alarm, it was the IPFS tests that were taking a long time to run)

@luizirber luizirber merged commit 2d26fc3 into latest Nov 1, 2020
@luizirber luizirber deleted the sbt_zip_default branch November 1, 2020 02:35
@ctb ctb mentioned this pull request Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch sourmash index to producing .sbt.zip files by default
2 participants