-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] change default behavior in lca summarize
#1175
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #1175 +/- ##
==========================================
+ Coverage 84.11% 93.21% +9.10%
==========================================
Files 99 75 -24
Lines 9258 5910 -3348
==========================================
- Hits 7787 5509 -2278
+ Misses 1471 401 -1070
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
lca summarize
ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
thanks! |
Two changes to
lca summarize
for better default behavior for 4.0 ----singleton
behavior inlca summarize
the default, and remove old merge-all-signatures behavior.--with-abundance
the default, replace with--ignore-abundance
Fixes #929.
Fixes #1024.
Nice code simplification too :)
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?