Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] change default behavior in lca summarize #1175

Merged
merged 6 commits into from
Aug 19, 2020
Merged

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Aug 18, 2020

Two changes to lca summarize for better default behavior for 4.0 --

  • Make --singleton behavior in lca summarize the default, and remove old merge-all-signatures behavior.
  • Make --with-abundance the default, replace with --ignore-abundance

Fixes #929.
Fixes #1024.

Nice code simplification too :)

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #1175 into latest will increase coverage by 9.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1175      +/-   ##
==========================================
+ Coverage   84.11%   93.21%   +9.10%     
==========================================
  Files          99       75      -24     
  Lines        9258     5910    -3348     
==========================================
- Hits         7787     5509    -2278     
+ Misses       1471      401    -1070     
Flag Coverage Δ
#rusttests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sourmash/cli/lca/summarize.py 100.00% <100.00%> (ø)
sourmash/lca/command_summarize.py 91.26% <100.00%> (+1.33%) ⬆️
src/core/src/ffi/signature.rs
src/core/src/signature.rs
src/core/src/ffi/minhash.rs
src/core/src/index/sbt/mhbt.rs
src/core/tests/test.rs
src/core/src/ffi/nodegraph.rs
src/core/src/wasm.rs
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e988d2c...e60e464. Read the comment docs.

@ctb ctb changed the title [MRG] remove default merge behavior in lca summarize [MRG] change default behavior in lca summarize Aug 18, 2020
@ctb
Copy link
Contributor Author

ctb commented Aug 18, 2020

ready for review!

Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ctb ctb merged commit 1546d18 into latest Aug 19, 2020
@ctb ctb deleted the lca_summarize_singleton branch August 19, 2020 14:02
@ctb
Copy link
Contributor Author

ctb commented Aug 19, 2020

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants