-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Add deduction of ksize from query #119
Conversation
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
==========================================
- Coverage 85.6% 85.44% -0.17%
==========================================
Files 13 13
Lines 1897 1903 +6
Branches 52 52
==========================================
+ Hits 1624 1626 +2
- Misses 262 266 +4
Partials 11 11
Continue to review full report at Codecov.
|
Note addition of |
I'll think again about |
"""Walk nodes in `tree` to find out ksize""" | ||
for node in tree.nodes.values(): | ||
if isinstance(node, sourmash_lib.sbtmh.SigLeaf): | ||
return node.data.estimator.ksize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to investigate why codecov thinks this line isn't covered
On Wed, Apr 12, 2017 at 01:10:07AM -0700, Tim Head wrote:
I'll think again about `load_one_signature`, though it seems right now we do Ok with the existing loaders. They all seem to error when there is ambiguity.
load_one_signature is primarily designed for my use at command line and
in little scripts, but by my understanding it should reduce some code
and the use of assert statements in commands.py, too.
|
18a4d61
to
600cb57
Compare
Refreshed this. Still not quite sure how to modify this to use |
Refresh this and I'll merge. Note: may fix #189 too. |
Also note: if you make these branches on the dib-lab repo I can refresh... |
When the query only contains on k-size then use that unless user specified a particular k.
Sorry about the foreign branch, keep forgetting. |
Updated in #224 - might as well just merge that one, I guess? |
Fixed by #224 |
Fixes #105
When the query only contains one k-size then use that unless
user specified a particular k. Same when there is only one molecule type.
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?