Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] remove 10x support #1229

Merged
merged 1 commit into from
Nov 2, 2020
Merged

[MRG] remove 10x support #1229

merged 1 commit into from
Nov 2, 2020

Conversation

luizirber
Copy link
Member

@luizirber luizirber commented Nov 1, 2020

See #1158 for discussion.

TODO for 4.0 release

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented Nov 1, 2020

Codecov Report

Merging #1229 into latest will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1229      +/-   ##
==========================================
- Coverage   83.34%   83.29%   -0.06%     
==========================================
  Files         103      103              
  Lines        9620     9588      -32     
==========================================
- Hits         8018     7986      -32     
  Misses       1602     1602              
Flag Coverage Δ
rusttests 67.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sourmash/cli/compute.py 100.00% <ø> (ø)
sourmash/command_compute.py 97.51% <ø> (-0.20%) ⬇️
sourmash/command_sketch.py 89.93% <ø> (-0.19%) ⬇️
src/core/src/cmd.rs 86.88% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90784fe...ba0b5cb. Read the comment docs.

@luizirber luizirber added the 4.0 issues to address for a 4.0 release label Nov 1, 2020
@luizirber luizirber changed the title [WIP] remove 10x support [MRG] remove 10x support Nov 1, 2020
@luizirber
Copy link
Member Author

Ready for review and merge @ctb @olgabot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.0 issues to address for a 4.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants