[MRG] CI: moving python tests from travis to GH actions #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## latest #1249 +/- ##
===========================================
+ Coverage 43.69% 92.87% +49.18%
===========================================
Files 103 76 -27
Lines 9533 5977 -3556
===========================================
+ Hits 4165 5551 +1386
+ Misses 5368 426 -4942
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
luizirber
force-pushed
the
python_gh
branch
3 times, most recently
from
c9a4266
to
b903c5e
Compare
luizirber
changed the title
|
Ready for review and merge @ctb |
luizirber
commented
Dec 8, 2020
| @@ -3,6 +3,7 @@ name: cibuildwheel | |||
| on: | |||
| push: | |||
| branches: [latest] | |||
| tags: v* | |||
There was a problem hiding this comment.
(and this should fix building wheels on new tags, @ctb: try to force push 4.0.0a2 again after this is merged =])
This was referenced Feb 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we consume the Travis credits too fast and it is blocking our PRs. This PR moves the Python tests from Travis to GitHub Actions.
I made the Python tests on 3.9 required, as well as wheel building on Linux and MacOS.
Travis is still running arm64 and ppcle64 wheels on new tags, but otherwise all tests were transferred to GitHub Actions with this PR.
TODO
Checklist
make testDid it pass the tests?make coverageIs the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?