Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Dev updates (configs and doc) #1298

Merged
merged 11 commits into from
Feb 4, 2021
Merged

[MRG] Dev updates (configs and doc) #1298

merged 11 commits into from
Feb 4, 2021

Conversation

luizirber
Copy link
Member

@luizirber luizirber commented Feb 3, 2021

I need the shell.nix now that both my dev machines are running NixOS. This PR updates an earlier version, adding all the supported Python versions and using niv for versioning/reproducibility of the environment.

TODO

  • add instructions to dev documentation (also add tox-conda info?)
  • Add CI for checking if the environment is working? (only py39 tests)
  • Also add CI for tox-conda? (only py39 tests)

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #1298 (035c5d7) into latest (43ae278) will increase coverage by 5.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1298      +/-   ##
==========================================
+ Coverage   88.69%   93.96%   +5.26%     
==========================================
  Files         125       98      -27     
  Lines       18281    14665    -3616     
  Branches     1440     1440              
==========================================
- Hits        16215    13780    -2435     
+ Misses       1819      638    -1181     
  Partials      247      247              
Flag Coverage Δ
python 93.96% <ø> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/tests/minhash.rs
src/core/src/index/linear.rs
src/core/src/ffi/hyperloglog.rs
src/core/src/index/storage.rs
src/core/src/sketch/minhash.rs
src/core/src/sketch/nodegraph.rs
src/core/src/wasm.rs
src/core/src/index/sbt/mod.rs
src/core/src/ffi/nodegraph.rs
src/core/src/ffi/cmd/compute.rs
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43ae278...035c5d7. Read the comment docs.

@luizirber luizirber changed the title [WIP] Nix configuration updates [WIP] Dev updates (configs and doc) Feb 4, 2021
@luizirber luizirber changed the title [WIP] Dev updates (configs and doc) [MRG] Dev updates (configs and doc) Feb 4, 2021
@luizirber
Copy link
Member Author

I think this is ready for review and merge. Do the new install instructions make sense?

Pinging @ctb @olgabot @bluegenes on this one =]

@luizirber luizirber merged commit 63f545b into latest Feb 4, 2021
@luizirber luizirber deleted the nix branch February 4, 2021 16:21
@ctb ctb mentioned this pull request Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants