Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Switch use of load_signatures over to load_file_as_signatures throughout. #1304

Merged
merged 2 commits into from
Feb 5, 2021

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Feb 5, 2021

Per #1296 (comment)

This fixes deprecation warnings caused by merge of #1279.

Note that, viz tests/test_api.py, we no longer provide a top-level / public API for loading signatures from strings.

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #1304 (c3ec1e9) into latest (3e3cd35) will increase coverage by 5.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1304      +/-   ##
==========================================
+ Coverage   88.70%   93.96%   +5.25%     
==========================================
  Files         125       98      -27     
  Lines       18294    14680    -3614     
  Branches     1437     1437              
==========================================
- Hits        16228    13794    -2434     
+ Misses       1821      641    -1180     
  Partials      245      245              
Flag Coverage Δ
python 93.96% <100.00%> (-0.01%) ⬇️
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_api.py 100.00% <100.00%> (ø)
tests/test_cmd_signature.py 100.00% <100.00%> (ø)
tests/test_compare.py 100.00% <100.00%> (ø)
tests/test_index.py 100.00% <100.00%> (ø)
tests/test_sbt.py 100.00% <100.00%> (ø)
src/sourmash/__init__.py 91.66% <0.00%> (-2.78%) ⬇️
src/core/src/signature.rs
src/core/src/sketch/minhash.rs
src/core/src/index/sbt/mhbt.rs
src/core/src/ffi/cmd/compute.rs
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e3cd35...c3ec1e9. Read the comment docs.

@luizirber luizirber merged commit bc87da7 into latest Feb 5, 2021
@luizirber luizirber deleted the fix_new_deprecations branch February 5, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants