Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add migration docs and release notes #1316

Merged
merged 8 commits into from
Feb 9, 2021
Merged

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Feb 9, 2021

Add release notes and migration docs to the 4.0 doc update.

NOTE: PR into #1283.

TODO:

  • add details about traverse-directory and lca summarize from this comment
  • add details from this comment about index and lca index command lines
  • add details from this comment about MinHash changes - downsample and is_molecule type, in particular.

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

Copy link
Contributor

@taylorreiter taylorreiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Added some comments, compliments, and small suggestions.

doc/release-notes/sourmash-4.0.md Show resolved Hide resolved
doc/release-notes/sourmash-4.0.md Outdated Show resolved Hide resolved
doc/release-notes/sourmash-4.0.md Outdated Show resolved Hide resolved
doc/release-notes/sourmash-4.0.md Outdated Show resolved Hide resolved
doc/support.md Outdated Show resolved Hide resolved
doc/support.md Outdated Show resolved Hide resolved
doc/support.md Show resolved Hide resolved
doc/support.md Show resolved Hide resolved
@ctb
Copy link
Contributor Author

ctb commented Feb 9, 2021

thank you very much @taylorreiter !!

Copy link
Contributor

@taylorreiter taylorreiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, I've added some comments, compliments, and suggestions.

@ctb
Copy link
Contributor Author

ctb commented Feb 9, 2021

@taylorreiter please see last set of changes here, b041bb8.

@luizirber I'm happy to wait for your review if you like, just lmk.

@ctb
Copy link
Contributor Author

ctb commented Feb 9, 2021

thanks, fixed! gonna merge before luiz jumps in 😁

@ctb ctb merged commit 219e606 into docs_4.0 Feb 9, 2021
@ctb ctb deleted the docs_4.0_release_notes branch February 9, 2021 18:15
ctb added a commit that referenced this pull request Feb 17, 2021
* start adjusting docs

* add migration links

* switch compute over to sketch in most of the markdown docs

* fix --scaled and --track-abundance thruought

* formatting and wording fixes

* add sourmash sketch docs

* substantial update for API examples

* add ToC to api-example

* fix heading for API section

* bold API examples link

* (untested) update of tutorials to use sourmash sketch

* update link targets

* updates of indexed databases

* typos in versioning (#1314)

* Apply suggestions from code review

Co-authored-by: Taylor Reiter <[email protected]>

* Update doc/api-example.md

Co-authored-by: Taylor Reiter <[email protected]>

* updated with suggestions from @taylorreiter doc review

* added section on sketch naming

* [WIP] add migration docs and release notes (#1316)

* add migration docs and release notes

* Update doc/support.md

Co-authored-by: Taylor Reiter <[email protected]>

* Update doc/support.md

Co-authored-by: Taylor Reiter <[email protected]>

* Update doc/release-notes/sourmash-4.0.md

Co-authored-by: Taylor Reiter <[email protected]>

* Update doc/release-notes/sourmash-4.0.md

Co-authored-by: Taylor Reiter <[email protected]>

* Update doc/release-notes/sourmash-4.0.md

Co-authored-by: Taylor Reiter <[email protected]>

* update with last set of changes

* add missing line break

Co-authored-by: Taylor Reiter <[email protected]>

* resolve missing link

* update tutorials and notebooks for 4.0

* [MRG] update the migration guide for 4.0 with version pinning instructions (#1330)

* update 4.0 migration docs with version pinning instructions

* update migration docs

* Apply suggestions from code review

Co-authored-by: Luiz Irber <[email protected]>

* Apply suggestions from code review

Co-authored-by: Luiz Irber <[email protected]>

Co-authored-by: Taylor Reiter <[email protected]>
Co-authored-by: Luiz Irber <[email protected]>
ctb added a commit that referenced this pull request Feb 18, 2021
* start adjusting docs

* add migration links

* switch compute over to sketch in most of the markdown docs

* fix --scaled and --track-abundance thruought

* formatting and wording fixes

* add sourmash sketch docs

* substantial update for API examples

* add ToC to api-example

* fix heading for API section

* bold API examples link

* (untested) update of tutorials to use sourmash sketch

* update link targets

* updates of indexed databases

* typos in versioning (#1314)

* Apply suggestions from code review

Co-authored-by: Taylor Reiter <[email protected]>

* Update doc/api-example.md

Co-authored-by: Taylor Reiter <[email protected]>

* updated with suggestions from @taylorreiter doc review

* added section on sketch naming

* [WIP] add migration docs and release notes (#1316)

* add migration docs and release notes

* Update doc/support.md

Co-authored-by: Taylor Reiter <[email protected]>

* Update doc/support.md

Co-authored-by: Taylor Reiter <[email protected]>

* Update doc/release-notes/sourmash-4.0.md

Co-authored-by: Taylor Reiter <[email protected]>

* Update doc/release-notes/sourmash-4.0.md

Co-authored-by: Taylor Reiter <[email protected]>

* Update doc/release-notes/sourmash-4.0.md

Co-authored-by: Taylor Reiter <[email protected]>

* update with last set of changes

* add missing line break

Co-authored-by: Taylor Reiter <[email protected]>

* resolve missing link

* update tutorials and notebooks for 4.0

* fix link; add GTDB mention; logo positioning

* minor fixes and updates

* no need for pysam and htslib any more

* fix words

* Update README.md

Co-authored-by: Luiz Irber <[email protected]>

Co-authored-by: Taylor Reiter <[email protected]>
Co-authored-by: Luiz Irber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants