-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] add migration docs and release notes #1316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Added some comments, compliments, and small suggestions.
Co-authored-by: Taylor Reiter <[email protected]>
Co-authored-by: Taylor Reiter <[email protected]>
Co-authored-by: Taylor Reiter <[email protected]>
Co-authored-by: Taylor Reiter <[email protected]>
Co-authored-by: Taylor Reiter <[email protected]>
thank you very much @taylorreiter !! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, I've added some comments, compliments, and suggestions.
@taylorreiter please see last set of changes here, b041bb8. @luizirber I'm happy to wait for your review if you like, just lmk. |
thanks, fixed! gonna merge before luiz jumps in 😁 |
* start adjusting docs * add migration links * switch compute over to sketch in most of the markdown docs * fix --scaled and --track-abundance thruought * formatting and wording fixes * add sourmash sketch docs * substantial update for API examples * add ToC to api-example * fix heading for API section * bold API examples link * (untested) update of tutorials to use sourmash sketch * update link targets * updates of indexed databases * typos in versioning (#1314) * Apply suggestions from code review Co-authored-by: Taylor Reiter <[email protected]> * Update doc/api-example.md Co-authored-by: Taylor Reiter <[email protected]> * updated with suggestions from @taylorreiter doc review * added section on sketch naming * [WIP] add migration docs and release notes (#1316) * add migration docs and release notes * Update doc/support.md Co-authored-by: Taylor Reiter <[email protected]> * Update doc/support.md Co-authored-by: Taylor Reiter <[email protected]> * Update doc/release-notes/sourmash-4.0.md Co-authored-by: Taylor Reiter <[email protected]> * Update doc/release-notes/sourmash-4.0.md Co-authored-by: Taylor Reiter <[email protected]> * Update doc/release-notes/sourmash-4.0.md Co-authored-by: Taylor Reiter <[email protected]> * update with last set of changes * add missing line break Co-authored-by: Taylor Reiter <[email protected]> * resolve missing link * update tutorials and notebooks for 4.0 * [MRG] update the migration guide for 4.0 with version pinning instructions (#1330) * update 4.0 migration docs with version pinning instructions * update migration docs * Apply suggestions from code review Co-authored-by: Luiz Irber <[email protected]> * Apply suggestions from code review Co-authored-by: Luiz Irber <[email protected]> Co-authored-by: Taylor Reiter <[email protected]> Co-authored-by: Luiz Irber <[email protected]>
* start adjusting docs * add migration links * switch compute over to sketch in most of the markdown docs * fix --scaled and --track-abundance thruought * formatting and wording fixes * add sourmash sketch docs * substantial update for API examples * add ToC to api-example * fix heading for API section * bold API examples link * (untested) update of tutorials to use sourmash sketch * update link targets * updates of indexed databases * typos in versioning (#1314) * Apply suggestions from code review Co-authored-by: Taylor Reiter <[email protected]> * Update doc/api-example.md Co-authored-by: Taylor Reiter <[email protected]> * updated with suggestions from @taylorreiter doc review * added section on sketch naming * [WIP] add migration docs and release notes (#1316) * add migration docs and release notes * Update doc/support.md Co-authored-by: Taylor Reiter <[email protected]> * Update doc/support.md Co-authored-by: Taylor Reiter <[email protected]> * Update doc/release-notes/sourmash-4.0.md Co-authored-by: Taylor Reiter <[email protected]> * Update doc/release-notes/sourmash-4.0.md Co-authored-by: Taylor Reiter <[email protected]> * Update doc/release-notes/sourmash-4.0.md Co-authored-by: Taylor Reiter <[email protected]> * update with last set of changes * add missing line break Co-authored-by: Taylor Reiter <[email protected]> * resolve missing link * update tutorials and notebooks for 4.0 * fix link; add GTDB mention; logo positioning * minor fixes and updates * no need for pysam and htslib any more * fix words * Update README.md Co-authored-by: Luiz Irber <[email protected]> Co-authored-by: Taylor Reiter <[email protected]> Co-authored-by: Luiz Irber <[email protected]>
Add release notes and migration docs to the 4.0 doc update.
NOTE: PR into #1283.
TODO:
Checklist
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?