-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] update output from gather w/o abundances, so that abund output is empty #1328
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #1328 +/- ##
==========================================
+ Coverage 88.73% 94.06% +5.33%
==========================================
Files 123 96 -27
Lines 18116 14509 -3607
Branches 1398 1399 +1
==========================================
- Hits 16075 13648 -2427
+ Misses 1802 622 -1180
Partials 239 239
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Ready for review & merge @luizirber! |
@bluegenes could review it also, if she's feeling like it ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - None
/ empty columns are much clearer than zeroes!
lgtm
thank you! |
Based on dib-lab/genome-grist#45, there is a potential confusion where
sourmash gather
outputs CSVs that have zeros in three columns (average_abund
,median_abund
,std_abund
) when NOT using abundances in calculations.This PR changes output CSVs so that
None
is used as default value, which results in empty CSV fields. I think this is much clearer than putting a zero in the field!Addresses part of dib-lab/genome-grist#45 (comment)
TODO:
Checklist
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?