replace notify format usage with f-strings instead (#1409) (#1418) #1422
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #1422 +/- ##
==========================================
+ Coverage 89.27% 94.49% +5.21%
==========================================
Files 123 96 -27
Lines 18790 15176 -3614
Branches 1447 1447
==========================================
- Hits 16775 14340 -2435
+ Misses 1782 603 -1179
Partials 233 233
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
hi @itsabhianant this looks good - should I review? |
|
(you should "update branch", too, since we've merged something into latest since you started this) |
|
Hi @ctb, I have updated the branch as per your instructions. |
|
ok! I'll wait for the tests to pass and then merge it. request - could you edit the top comment to say something like, so that the issues are linked? You did put the relevant issue numbers in the title of the pull request, but GitHub doesn't interlink the issues based on things in the title, it seems. Thanks! |
itsabhianant
changed the title
|
Hi @ctb, I don't know how to that as I am new to GitHub. I searched for it on the web but that didn't help. Could you please help me more briefly? Should we add links in the same way we do for README.md? |
|
sure! I saw you changed the title, but I think the old title was mostly fine so you should change that back ;). to edit the PR description, go to the '...' in the upper right of the first text box, just above "Checklist", and select "Edit". |
itsabhianant
changed the title
|
I updated the top comment as per your instructions @ctb . Is it fine or there are more changes to be made? Thanks for the help. |
|
hi @itsabhianant, if you use the format here, it will automatically close #1418 when this is merged, which is the preferred behavior. As it is, it properly references the two issues but won't close #1418. (note you can use too, github understands both the full link to the issue and just the issue number) |
|
Hi @ctb, I am getting an error while checking that displays: |
|
no worries, that's not your fault! it's just a sporadic problem with RTD. |
|
Oh, thanks... |
|
yep - can you please update the comment at the top, tho, per #1422 (comment)? That way the relevant issue will be closed when I merge. |
|
(you don't want the parantheses around the issue numbers. to see that you've got it right, look at the "linked issues" on the right where it says "Successfully merging this pull request may close these issues." Right now, it says "None yet." It should mention #1418) |
|
I have done that now it says: Thanks for all the help sir. I learned a lot from you. |
|
Thank you for your contribution! If you would like to be listed as a contributor in future publications, we will need your ORCID; you can get one here if you don't have one already. |
thank YOU! if you are interested in trying out another issue, I'd suggest looking at one that involves editing/updating some test code. I can tag you in on two or three if you are interested. But no worries if not! |
|
where should I give my ORCID?
…On Tue, 30 Mar 2021 at 20:11, C. Titus Brown ***@***.***> wrote:
Thank you for your contribution! If you would like to be listed as a
contributor in future publications, we will need your ORCID; you can get
one here <https://orcid.org/register> if you don't have one already.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1422 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATMGTQIM6T4YREMPHY2HVZLTGHPJJANCNFSM42ABGYOQ>
.
|
|
On Tue, Mar 30, 2021 at 07:49:57AM -0700, Abhishek Anant wrote:
where should I give my ORCID?
please just put it in a comment on this pull request. thanks!
|
Yes, I would love to work on other issues. Please do tag me for editing/updating some test code. |
Fixes #1418
Ref #1409