-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] replace utils.TempDirectory with run tmp #1502
Conversation
your PR is looking good, @hehouts ! I think you're probably interested in |
Codecov Report
@@ Coverage Diff @@
## latest #1502 +/- ##
==========================================
+ Coverage 90.25% 95.27% +5.02%
==========================================
Files 126 99 -27
Lines 21109 17405 -3704
Branches 1589 1589
==========================================
- Hits 19051 16583 -2468
+ Misses 1829 593 -1236
Partials 229 229
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
looking good! |
@ctb @bluegenes please review :) The test print statements havent changed, so Im pretty sure theyre still working |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
@hehouts when it passes all the tests (I updated from latest again), please go ahead and merge ;) |
Updated to
runtmp
intest_cmd_signature.py
(1 test) andtest_index.py
(3 tests)Chips away at #1386