-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] add --include-db-pattern
and --exclude-db-pattern
to search/gather
#1871
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #1871 +/- ##
==========================================
+ Coverage 82.52% 90.55% +8.02%
==========================================
Files 121 91 -30
Lines 13061 8903 -4158
Branches 1751 1756 +5
==========================================
- Hits 10779 8062 -2717
+ Misses 2016 578 -1438
+ Partials 266 263 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I think this may be ready for review @bluegenes |
--include-db-pattern
and --exclude-db-pattern
to search/gather--include-db-pattern
and --exclude-db-pattern
to search/gather
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, so clean and powerful 🎉
some minor comments and questions, otherwise lgtm!
will merge upon tests passing, after a quick re-review of the changes I just made :) |
This PR adds
--include-db-pattern
and--exclude-db-pattern
tosourmash search
,gather
,prefetch
,compare
,sig cat
,sig extract
, andsig rename
using the manifest column-filtering code introduced in #1864.Fixes #1865
Misc thoughts:
commands.py
is getting kinda ugly, seems like there might be some room for significant refactoring...TODO:
compare
sig cat
,sig extract
, andsig rename