Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] create ComputeParameters.from_manifest_row in support of sourmash sketch fromfile #1886

Merged
merged 3 commits into from
Mar 19, 2022

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Mar 14, 2022

This PR is in support of #1885.

This PR refactors manifest row extraction into ComputeParameters.from_manifest_row.

@ctb ctb changed the title [WIP] [WIP] more sourmash sketch fromfile support changes Mar 14, 2022
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #1886 (94357a8) into latest (8f4c94c) will increase coverage by 7.89%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1886      +/-   ##
==========================================
+ Coverage   82.64%   90.54%   +7.89%     
==========================================
  Files         121       91      -30     
  Lines       13148     8957    -4191     
  Branches     1772     1774       +2     
==========================================
- Hits        10866     8110    -2756     
+ Misses       2017      581    -1436     
- Partials      265      266       +1     
Flag Coverage Δ
python 90.54% <84.21%> (-0.02%) ⬇️
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/command_sketch.py 88.20% <50.00%> (-0.39%) ⬇️
src/sourmash/command_compute.py 92.45% <88.23%> (-0.24%) ⬇️
src/core/src/from.rs
src/core/src/ffi/utils.rs
src/core/src/sketch/hyperloglog/estimators.rs
src/core/src/signature.rs
src/core/src/index/mod.rs
src/core/src/ffi/signature.rs
src/core/src/encodings.rs
src/core/src/ffi/index/revindex.rs
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f4c94c...94357a8. Read the comment docs.

@ctb ctb changed the title [WIP] more sourmash sketch fromfile support changes [MRG] create ComputeParameters.from_manifest_row in support of sourmash sketch fromfile Mar 19, 2022
@ctb
Copy link
Contributor Author

ctb commented Mar 19, 2022

@sourmash-bio/devs ready for review and merge!

src/sourmash/command_sketch.py Show resolved Hide resolved
@ctb ctb merged commit dd5c013 into latest Mar 19, 2022
@ctb ctb deleted the update/more_sketch_fromfile_support branch March 19, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants