-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] add sig collect
command
#2036
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #2036 +/- ##
==========================================
+ Coverage 84.16% 91.73% +7.57%
==========================================
Files 129 99 -30
Lines 15134 10960 -4174
Branches 2133 2151 +18
==========================================
- Hits 12737 10054 -2683
+ Misses 2098 607 -1491
Partials 299 299
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…o add/sig_collect
Ready for review & merge @sourmash-bio/devs! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple minor suggestions, otherwise lgtm!
Co-authored-by: Tessa Pierce Ward <[email protected]>
Co-authored-by: Tessa Pierce Ward <[email protected]>
thank you :) |
Adds
sourmash sig collect
by integrating sigs-to-manifest.py into sourmash.This is the code that's used to maintain a manifest of wort-genomes signatures, among other things - see #1965.
The main motivation behind this command addition is that it's really enabling for certain use cases, as shown most clearly by the way the documentation simplifies 😃 .
Guide into rendered docs from this PR: