-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EXP: Added derives for mem-dbg #3292
base: latest
Are you sure you want to change the base?
Conversation
@ctb could you kindly start the workflows? |
done! sorry, didn't see the button that needed pushing 😆 |
Looking into whether I can make mem-dbg work in 1.65.0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## latest #3292 +/- ##
=======================================
Coverage 86.75% 86.75%
=======================================
Files 137 137
Lines 15920 15920
Branches 2728 2728
=======================================
Hits 13812 13812
Misses 1799 1799
Partials 309 309
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Apparently in mem-dbg there is need for |
@LucaCappelletti94 please feel free to leave this PR open 'til then! - and I'll rename it to |
yeah, sorry, we are somewhat conservative with the MSRV, and 1.77 would be a very big bump. There is a question if we need to be that conservative, because end users don't need the Rust compiler for the Python extension (we have wheels), and we build wheels from latest stable. Most places we track packaging also have newer Rust versions, so that would be an argument to move MSRV faster too. |
@@ -21,6 +21,7 @@ authors = [ | |||
{ name="Colton Baumler", orcid="0000-0002-5926-7792" }, | |||
{ name="Olga Botvinnik", orcid="0000-0003-4412-7970" }, | |||
{ name="Phillip Brooks", orcid="0000-0003-3987-244X" }, | |||
{ name="Luca Cappelletti", orcid="0000-0002-1269-2038" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled this one into #3275 , which I'm going to merge today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok!
No change to API nor any other aspects are introduced in this pull request.