Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXP: Added derives for mem-dbg #3292

Open
wants to merge 2 commits into
base: latest
Choose a base branch
from

Conversation

LucaCappelletti94
Copy link
Contributor

  • Added support as an optional feature to mem_dbg, an easy way to compute memory requirements for a struct. It is useful for comparing this library with other implementations.

No change to API nor any other aspects are introduced in this pull request.

@LucaCappelletti94
Copy link
Contributor Author

@ctb could you kindly start the workflows?

@ctb
Copy link
Contributor

ctb commented Aug 15, 2024

@ctb could you kindly start the workflows?

done! sorry, didn't see the button that needed pushing 😆

@LucaCappelletti94
Copy link
Contributor Author

Looking into whether I can make mem-dbg work in 1.65.0

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.75%. Comparing base (bc22970) to head (42a2b8d).

Additional details and impacted files
@@           Coverage Diff           @@
##           latest    #3292   +/-   ##
=======================================
  Coverage   86.75%   86.75%           
=======================================
  Files         137      137           
  Lines       15920    15920           
  Branches     2728     2728           
=======================================
  Hits        13812    13812           
  Misses       1799     1799           
  Partials      309      309           
Flag Coverage Δ
hypothesis-py 25.40% <ø> (ø)
python 92.37% <ø> (ø)
rust 62.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucaCappelletti94
Copy link
Contributor Author

Apparently in mem-dbg there is need for core::mem::offset_of! which is not stable in version 1.65. Will ping this PR if mem-dbg introduces features that make it possible to compile on 1.65.

@ctb
Copy link
Contributor

ctb commented Aug 15, 2024

@LucaCappelletti94 please feel free to leave this PR open 'til then! - and I'll rename it to EXP: which is how I keep track of these things.

@ctb ctb changed the title Added derives for mem-dbg EXP: Added derives for mem-dbg Aug 15, 2024
@luizirber
Copy link
Member

yeah, sorry, we are somewhat conservative with the MSRV, and 1.77 would be a very big bump.

There is a question if we need to be that conservative, because end users don't need the Rust compiler for the Python extension (we have wheels), and we build wheels from latest stable. Most places we track packaging also have newer Rust versions, so that would be an argument to move MSRV faster too.

@@ -21,6 +21,7 @@ authors = [
{ name="Colton Baumler", orcid="0000-0002-5926-7792" },
{ name="Olga Botvinnik", orcid="0000-0003-4412-7970" },
{ name="Phillip Brooks", orcid="0000-0003-3987-244X" },
{ name="Luca Cappelletti", orcid="0000-0002-1269-2038" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled this one into #3275 , which I'm going to merge today

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants