-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: misc Rust updates to core #3297
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #3297 +/- ##
=======================================
Coverage 86.67% 86.68%
=======================================
Files 137 137
Lines 15998 16003 +5
Branches 2728 2728
=======================================
+ Hits 13867 13872 +5
Misses 1822 1822
Partials 309 309
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
for your delectation @luizirber |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 overall, but I think the load_sig
change should be reverted or better contextualized =]
Co-authored-by: Luiz Irber <[email protected]>
Co-authored-by: Luiz Irber <[email protected]>
ready once tests pass! thx |
A few useful things from the branchwater plugin perspective:
num
,scaled
, andn_hashes
inRecord
#[derive Clone]
toCollection
andCollectionSet
Collection::from_rocksdb(...)