Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: misc Rust updates to core #3297

Merged
merged 25 commits into from
Aug 19, 2024
Merged

MRG: misc Rust updates to core #3297

merged 25 commits into from
Aug 19, 2024

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Aug 18, 2024

A few useful things from the branchwater plugin perspective:

  • add getters to num, scaled, and n_hashes in Record
  • add misc documentation, based in part on descriptions in Feat: on-disk RevIndex based on RocksDB #2230
  • add #[derive Clone] to Collection and CollectionSet
  • add Collection::from_rocksdb(...)

Copy link

codecov bot commented Aug 18, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.68%. Comparing base (c621bd5) to head (b6640c2).
Report is 1 commits behind head on latest.

Files Patch % Lines
src/core/src/collection.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           latest    #3297   +/-   ##
=======================================
  Coverage   86.67%   86.68%           
=======================================
  Files         137      137           
  Lines       15998    16003    +5     
  Branches     2728     2728           
=======================================
+ Hits        13867    13872    +5     
  Misses       1822     1822           
  Partials      309      309           
Flag Coverage Δ
hypothesis-py 25.40% <ø> (ø)
python 92.37% <ø> (ø)
rust 62.92% <90.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctb ctb changed the title WIP: misc Rust updates to core MRG: misc Rust updates to core Aug 18, 2024
@ctb
Copy link
Contributor Author

ctb commented Aug 18, 2024

for your delectation @luizirber

Copy link
Member

@luizirber luizirber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 overall, but I think the load_sig change should be reverted or better contextualized =]

src/core/src/collection.rs Outdated Show resolved Hide resolved
src/core/src/collection.rs Outdated Show resolved Hide resolved
src/core/src/storage/mod.rs Outdated Show resolved Hide resolved
@ctb
Copy link
Contributor Author

ctb commented Aug 18, 2024

ready once tests pass! thx

@luizirber luizirber self-requested a review August 19, 2024 04:46
@luizirber luizirber merged commit d90c507 into latest Aug 19, 2024
44 checks passed
@luizirber luizirber deleted the misc_rs_updates branch August 19, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants