Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: enforce a single scaled on a CollectionSet #3397

Open
wants to merge 1 commit into
base: latest
Choose a base branch
from

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Nov 14, 2024

Addresses #3386

#3387 changed select to update Record.scaled to the desired scaled value. This PR changes CollectionSet to require that all scaled values be the same, which can now be achieved by running select ;).

It also adds a new method Collection::min_max_scaled() which makes it easy to retrieve scaled for a Collection.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.46%. Comparing base (97e7808) to head (2ce356d).

Files with missing lines Patch % Lines
src/core/src/collection.rs 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3397      +/-   ##
==========================================
- Coverage   86.47%   86.46%   -0.01%     
==========================================
  Files         137      137              
  Lines       16095    16100       +5     
  Branches     2219     2219              
==========================================
+ Hits        13918    13921       +3     
- Misses       1870     1872       +2     
  Partials      307      307              
Flag Coverage Δ
hypothesis-py 25.43% <ø> (ø)
python 92.40% <ø> (ø)
rust 62.29% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant