Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Add --force flag to 'sourmash index' #446

Merged
merged 5 commits into from
Mar 12, 2018
Merged

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Mar 11, 2018

This lets us do

sourmash index genbank-k31 ../.sbt.genbank-k31 --traverse-directory -f

to reindex SBTs, etc. etc.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov-io
Copy link

codecov-io commented Mar 11, 2018

Codecov Report

Merging #446 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #446      +/-   ##
==========================================
+ Coverage   90.43%   90.48%   +0.04%     
==========================================
  Files          33       33              
  Lines        4882     4886       +4     
  Branches       36       36              
==========================================
+ Hits         4415     4421       +6     
+ Misses        466      464       -2     
  Partials        1        1
Impacted Files Coverage Δ
sourmash/sourmash_args.py 95.31% <100%> (ø) ⬆️
sourmash/commands.py 91.18% <100%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6400e42...7db1dcc. Read the comment docs.

@ctb
Copy link
Contributor Author

ctb commented Mar 11, 2018

Ready for review!

@luizirber luizirber mentioned this pull request Mar 12, 2018
@luizirber luizirber merged commit 0edb7c7 into master Mar 12, 2018
@luizirber luizirber deleted the add/force_index branch March 12, 2018 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants