Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] explore reverse indexing in LCA v2 databases #604

Closed
wants to merge 5 commits into from

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Jan 5, 2019

Ref #306 #581 and #533.

In #533, we ensured that LCA databases contained all input hashes, whether or not the owning signatures had a lineage assignment. This makes them good candidates for general reverse indexing, but modifications are needed to make this functionality usable and friendly. Here is where we are experimenting with better functionality.

One question to think about in this PR is this: is sourmash lca about taxonomic stuff, or about all LCA databases, and if the latter, should we rename them from lca databases to something else, and/or should we support taxonomic information in regular signatures (which would support them in SBTs)? Deep thunks to be plumbed.

Specifically, this PR:

Review checklist:

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb
Copy link
Contributor Author

ctb commented Apr 18, 2020

This PR is now superseded by #946 but I'm leaving it open until I think through the issues raised in the description, and maybe make them into new issues.

@ctb ctb closed this May 2, 2020
@ctb ctb deleted the lca_db/revindex branch May 2, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant