Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Document sourmash.figusage and behavior #859

Merged
merged 9 commits into from
Jul 22, 2020
Merged

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Jan 24, 2020

Add a notebook showcasing sourmash.fig for matrix/dendrogram plotting, and link the notebook into the documentation. Provide code examples for customizing the dendrogram.

Note that the binder environment loads correctly and the paths are set up properly, but until the next conda release this notebook won't work. Not 100% sure how to deal with that but it does render on the documentation site properly ;).

Fixes #501
Fixes #220
Fixes #1023
Fixes #311

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #859 into master will increase coverage by 9.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #859      +/-   ##
==========================================
+ Coverage   83.87%   93.04%   +9.16%     
==========================================
  Files          98       74      -24     
  Lines        9112     5810    -3302     
==========================================
- Hits         7643     5406    -2237     
+ Misses       1469      404    -1065     
Flag Coverage Δ
#rusttests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sourmash/cli/plot.py 100.00% <100.00%> (ø)
sourmash/commands.py 87.00% <100.00%> (+0.22%) ⬆️
sourmash/fig.py 89.13% <100.00%> (+0.24%) ⬆️
src/core/src/index/linear.rs
src/core/src/index/bigsi.rs
src/core/src/index/sbt/mhbt.rs
src/core/src/index/mod.rs
src/core/src/ffi/mod.rs
src/core/src/ffi/utils.rs
src/core/src/lib.rs
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 468e02c...45705a2. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ctb ctb mentioned this pull request Apr 7, 2020
@ctb ctb changed the title [WIP] Document sourmash.figusage and behavior [MRG] Document sourmash.figusage and behavior Jul 16, 2020
@ctb
Copy link
Contributor Author

ctb commented Jul 16, 2020

Ready for review! @taylorreiter @bluegenes

@ctb
Copy link
Contributor Author

ctb commented Jul 22, 2020

anyone? Bueller? ...Bueller?

:)

@taylorreiter
Copy link
Contributor

Should the binder work now?

This cell:

f, reordered_labels, reordered_matrix = fig.plot_composite_matrix(matrix, labels)

Gives me:

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-5-4d0f52de32a5> in <module>
----> 1 f, reordered_labels, reordered_matrix = fig.plot_composite_matrix(matrix, labels)

TypeError: cannot unpack non-iterable Figure object

@ctb
Copy link
Contributor Author

ctb commented Jul 22, 2020 via email

@taylorreiter
Copy link
Contributor

Then LGTM!

@ctb ctb merged commit f8d0262 into master Jul 22, 2020
@ctb ctb deleted the add/compare_notebook branch July 22, 2020 15:29
@ctb
Copy link
Contributor Author

ctb commented Jul 22, 2020

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants