-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Document sourmash.fig
usage and behavior
#859
Conversation
Codecov Report
@@ Coverage Diff @@
## master #859 +/- ##
==========================================
+ Coverage 83.87% 93.04% +9.16%
==========================================
Files 98 74 -24
Lines 9112 5810 -3302
==========================================
- Hits 7643 5406 -2237
+ Misses 1469 404 -1065
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
sourmash.fig
usage and behaviorsourmash.fig
usage and behavior
Ready for review! @taylorreiter @bluegenes |
anyone? Bueller? ...Bueller? :) |
Should the binder work now? This cell:
Gives me:
|
On Wed, Jul 22, 2020 at 07:46:38AM -0700, Taylor Reiter wrote:
Should the binder work now?
alas, it will not, until this is merged into master and released.
|
Then LGTM! |
thanks! |
Add a notebook showcasing
sourmash.fig
for matrix/dendrogram plotting, and link the notebook into the documentation. Provide code examples for customizing the dendrogram.sourmash compare
outputNote that the binder environment loads correctly and the paths are set up properly, but until the next conda release this notebook won't work. Not 100% sure how to deal with that but it does render on the documentation site properly ;).
Fixes #501
Fixes #220
Fixes #1023
Fixes #311
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?