Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRG: fix argparse stuff in cluster command #245

Merged
merged 1 commit into from
Feb 27, 2024
Merged

MRG: fix argparse stuff in cluster command #245

merged 1 commit into from
Feb 27, 2024

Conversation

ctb
Copy link
Collaborator

@ctb ctb commented Feb 27, 2024

Note: PR into #234

This PR fixes a few nits:

  • the default argument to --similarity-column was a no-longer-valid column name
  • the help string for --threshold contained an unescaped % causing argparse to fail on -h
  • indents and spacing were adjusted

Ready for merge @bluegenes!

@ctb ctb mentioned this pull request Feb 27, 2024
Merged
bluegenes
bluegenes approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bluegenes bluegenes merged commit 3fa24da into add-cluster Feb 27, 2024
1 check passed
@bluegenes bluegenes deleted the add-cluster_ctb branch February 27, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluegenes bluegenes bluegenes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctb @bluegenes