Merge pull request #569 from soutaro/fix-not

Apply logic-type evaluation only if the node is `:send`
soutaro · Jun 10, 2022 · 8c36ed2 · 8c36ed2
2 parents 438c691 + 35bd27c
commit 8c36ed2
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/lib/steep/type_inference/logic_type_interpreter.rb b/lib/steep/type_inference/logic_type_interpreter.rb
@@ -132,9 +132,12 @@ def eval(env:, type:, node:)
               end
             end
           when AST::Types::Logic::Not
-            receiver, * = value_node.children
-            receiver_type = typing.type_of(node: receiver)
-            falsy_env, truthy_env = eval(env: env, type: receiver_type, node: receiver)
+            case value_node.type
+            when :send
+              receiver, * = value_node.children
+              receiver_type = typing.type_of(node: receiver)
+              falsy_env, truthy_env = eval(env: env, type: receiver_type, node: receiver)
+            end
           end
         else
           _, vars = decompose_value(node)

diff --git a/test/type_construction_test.rb b/test/type_construction_test.rb
@@ -5877,6 +5877,21 @@ def test_logic_not
     end
   end
 
+  def test_logic_not2
+    with_checker(<<-RBS) do |checker|
+    RBS
+      source = parse_ruby(<<-RUBY)
+a = !Object.new
+a || true
+      RUBY
+
+      with_standard_construction(checker, source) do |construction, typing|
+        construction.synthesize(source.node)
+        assert_no_error typing
+      end
+    end
+  end
+
   def test_logic_and
     with_checker(<<-RBS) do |checker|
     RBS