Make record type #to_s deterministic

soutaro · Aug 26, 2020 · e2adab5 · e2adab5
1 parent 15b1df9
commit e2adab5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/steep/ast/types/record.rb b/lib/steep/ast/types/record.rb
@@ -26,7 +26,10 @@ def subst(s)
         end
 
         def to_s
-          "{ #{elements.map {|key, value| "#{key.inspect} => #{value}" }.join(", ")} }"
+          strings = elements.keys.sort.map do |key|
+            "#{key.inspect} => #{elements[key]}"
+          end
+          "{ #{strings.join(", ")} }"
         end
 
         def free_variables()

diff --git a/smoke/hash/d.rb b/smoke/hash/d.rb
@@ -2,5 +2,5 @@
 
 params = { id: 30, name: "Matz" }
 
-# !expects IncompatibleAssignment: lhs_type={ :name => ::String, :id => ::Integer }, rhs_type={ :id => ::String, :name => ::String, :email => ::String }
+# !expects IncompatibleAssignment: lhs_type={ :id => ::Integer, :name => ::String }, rhs_type={ :email => ::String, :id => ::String, :name => ::String }
 params = { id: "30", name: "foo", email: "[email protected]" }