refactor: Use Hash#fetch instead of Hash#[] to resolve type errors #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
commented
Oct 18, 2024
| @@ -46,7 +46,7 @@ def collect_changes(request) | |||
|
|
|||
| changes[path] ||= [] | |||
| request[:params][:contentChanges].each do |change| | |||
| changes[path] << Services::ContentChange.new( | |||
| changes.fetch(path) << Services::ContentChange.new( | |||
There was a problem hiding this comment.
I feel a bit strange about the combination of Hash#fetch and Array#<<...
| when singleton_method | ||
| methods = factory.definition_builder.build_singleton(type_name).methods | ||
|
|
||
| if singleton_method == :new | ||
| methods[:new] || methods[:initialize] | ||
| methods[:new] || methods.fetch(:initialize) |
There was a problem hiding this comment.
This is also a bit strange. The left hand is #[], but the right hand is #fetch. It's a little difficult to understand the behavior for me.
tk0miya
force-pushed
the
refactor/Hash.fetch
branch
from
41350c8
to
61a9792
Compare
tk0miya
changed the title
tk0miya
force-pushed
the
refactor/Hash.fetch
branch
from
61a9792
to
f706145
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
135 -> 47
Note:
Hash#fetchraises KeyError. So we need to merge this carefully. I'm okay to divide this PR to smaller ones.