Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix print error with absolute path #508

Merged
merged 2 commits into from
Mar 11, 2022
Merged

Fix print error with absolute path #508

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5a9aa0
Use absolute path to read file for print result
matsubara0507 Mar 11, 2022
7dc8a54
Refactor path variable is absolute
matsubara0507 Mar 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/steep/drivers/check.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,8 @@ def print_result(project:, notifications:)
total = errors.sum {|notification| notification[:diagnostics].size }

errors.each do |notification|
path = project.relative_path(Pathname(URI.parse(notification[:uri]).path))
buffer = RBS::Buffer.new(name: path, content: path.read)
path = Pathname(URI.parse(notification[:uri]).path)
buffer = RBS::Buffer.new(name: project.relative_path(path), content: project.absolute_path(path).read)
matsubara0507 marked this conversation as resolved.
Show resolved Hide resolved
printer = DiagnosticPrinter.new(buffer: buffer, stdout: stdout)

notification[:diagnostics].each do |diag|
Expand Down