Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip non-target ruby code on steep stats #509

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Conversation

soutaro
Copy link
Owner

@soutaro soutaro commented Mar 11, 2022

Errors were reported when steep stats receives non-project Ruby file.

[Steep 0.49.0] [typecheck:typecheck@5] [background] Unexpected error: #<NoMethodError: undefined method `name' for nil:NilClass

            signature_service = signature_services[target.name]
                                                         ^^^^^>
[Steep 0.49.0] [typecheck:typecheck@5] [background]   /Users/soutaro/src/steep/lib/steep/services/type_check_service.rb:274:in `block (2 levels) in typecheck_source'
[Steep 0.49.0] [typecheck:typecheck@5] [background]   /Users/soutaro/src/steep/lib/steep.rb:166:in `measure'
[Steep 0.49.0] [typecheck:typecheck@5] [background]   /Users/soutaro/src/steep/lib/steep/services/type_check_service.rb:273:in `block in typecheck_source'
[Steep 0.49.0] [typecheck:typecheck@5] [background]   /Users/soutaro/src/steep/vendor/bundle/ruby/3.1.0/gems/activesupport-7.0.2.2/lib/active_support/tagged_logging.rb:99:in `block in tagged'
[Steep 0.49.0] [typecheck:typecheck@5] [background]   /Users/soutaro/src/steep/vendor/bundle/ruby/3.1.0/gems/activesupport-7.0.2.2/lib/active_support/tagged_logging.rb:37:in `tagged'
[Steep 0.49.0] [typecheck:typecheck@5] [background]   /Users/soutaro/src/steep/vendor/bundle/ruby/3.1.0/gems/activesupport-7.0.2.2/lib/active_support/tagged_logging.rb:99:in `tagged'
[Steep 0.49.0] [typecheck:typecheck@5] [background]   /Users/soutaro/src/steep/lib/steep/services/type_check_service.rb:272:in `typecheck_source'
[Steep 0.49.0] [typecheck:typecheck@5] [background]   /Users/soutaro/src/steep/lib/steep/server/type_check_worker.rb:182:in `handle_job'
[Steep 0.49.0] [typecheck:typecheck@5] [background]   /Users/soutaro/src/steep/lib/steep/server/base_worker.rb:54:in `block (2 levels) in run'
[Steep 0.49.0] [typecheck:typecheck@5] [background]   /Users/soutaro/src/steep/vendor/bundle/ruby/3.1.0/gems/activesupport-7.0.2.2/lib/active_support/tagged_logging.rb:99:in `block in tagged'
[Steep 0.49.0] [typecheck:typecheck@5] [background]   /Users/soutaro/src/steep/vendor/bundle/ruby/3.1.0/gems/activesupport-7.0.2.2/lib/active_support/tagged_logging.rb:37:in `tagged'
[Steep 0.49.0] [typecheck:typecheck@5] [background]   /Users/soutaro/src/steep/vendor/bundle/ruby/3.1.0/gems/activesupport-7.0.2.2/lib/active_support/tagged_logging.rb:99:in `tagged'
[Steep 0.49.0] [typecheck:typecheck@5] [background]   /Users/soutaro/src/steep/lib/steep/server/base_worker.rb:44:in `block in run'

@soutaro soutaro merged commit 7ce2d94 into master Mar 11, 2022
@soutaro soutaro deleted the skip-non-target-ruby-code branch March 11, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant