Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support shorthand hash for ruby 3.1 #567

Merged
merged 2 commits into from
Jun 10, 2022
Merged

Support shorthand hash for ruby 3.1 #567

merged 2 commits into from
Jun 10, 2022

Conversation

alpaca-tc
Copy link
Contributor

@alpaca-tc alpaca-tc commented Jun 5, 2022 •
edited
Loading

Fixed: #510

I have just started using steep. Thanks for the great project 😄
This PR implements support for ruby3.1 shorthand hash.

before output

lib/a.rb:6:14: [error] SyntaxError: unexpected token tRPAREN
│ Diagnostic ID: Ruby::SyntaxError
│
└ Hello.world(x:)

Detected 1 problem from 1 file

after output

No type error detected. 🧉

soutaro
soutaro approved these changes Jun 10, 2022
View reviewed changes
Copy link
Owner

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏

@soutaro soutaro enabled auto-merge June 10, 2022 06:41
@soutaro soutaro merged commit 438c691 into soutaro:master Jun 10, 2022
@soutaro soutaro mentioned this pull request Jun 11, 2022
Closed
@alpaca-tc alpaca-tc deleted the shorthand_hash branch June 11, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Diagnostic Ruby::SyntaxError occurrence disables other diagnostics
2 participants
@alpaca-tc @soutaro