-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add steep checkfile
command
#650
Conversation
@@ -36,4 +36,5 @@ Gem::Specification.new do |spec| | |||
spec.add_runtime_dependency "rbs", ">= 2.7.0.pre" | |||
spec.add_runtime_dependency "parallel", ">= 1.0.0" | |||
spec.add_runtime_dependency "terminal-table", ">= 2", "< 4" | |||
spec.add_runtime_dependency "securerandom", ">= 0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@soutaro Isn't securerandom
part of standard Ruby ? Why is this dependency necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rpiotaix-tc It's a default gem since Ruby 3.0, which is a gem and installed by default. So, you are right that we can skip writing this line.
I'm trying to help rbs collection
, which detects dependencies automatically from bundled gems. (The switching to rbs collection
is not finished on Steep repo.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@soutaro Seems to me it is included in ruby 2.6.6 (from a fresh installation using rbenv):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rpiotaix-tc It was a part of standard libraries before 3.0, not a gem. This is unnecessary, it works completely without the line.
Adding the dependency is to be more explicit and helps rbs collection
.
Spec: https://hackmd.io/8oBsfmIjQGKRCOJnYdzbvg?both