Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix location no method error #763

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Fix location no method error #763

merged 1 commit into from
Apr 24, 2023

Conversation

soutaro
Copy link
Owner

@soutaro soutaro commented Apr 21, 2023

Closes #692

@soutaro soutaro added this to the Steep 1.4 milestone Apr 21, 2023
soutaro
soutaro commented Apr 21, 2023
View reviewed changes
lib/steep/diagnostic/ruby.rb Outdated
node.loc.selector
loc = node.loc

if loc.respond_to?(:operator)
Copy link
Owner Author

@soutaro soutaro Apr 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using respond_to? as the Parser gem recommends.

https://github.com/whitequark/parser/blob/f7000f2359aad57352e413f490142152b50a6553/lib/parser/source/map.rb#L44-L48

@soutaro soutaro force-pushed the fix-location-no-method-error branch from 1f4ffac to 29df612 Compare April 22, 2023 00:20
@soutaro soutaro enabled auto-merge April 22, 2023 00:20
@soutaro soutaro force-pushed the fix-location-no-method-error branch from 80e8612 to 71b7232 Compare April 24, 2023 12:59
@soutaro
loc.selector may be undefined
88023ab 
For `+=` operator.
@soutaro soutaro force-pushed the fix-location-no-method-error branch from 71b7232 to 88023ab Compare April 24, 2023 13:09
@soutaro soutaro merged commit 1552adf into master Apr 24, 2023
@soutaro soutaro deleted the fix-location-no-method-error branch April 24, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Steep 1.4
Development

Successfully merging this pull request may close these issues.

undefined method 'selector' with usage of += when no method error would be raised
1 participant
@soutaro