Sovrn Adapter accept AdUnitCodes #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-gpp EX-4658 Update Prebid Server user sync for GPP
cpabst
approved these changes
Aug 23, 2023
| continue | ||
| } | ||
|
|
||
| imp.Ext = impExtBuffer |
There was a problem hiding this comment.
Do we really want to send whole bidder object in the ext object of the imp?
There was a problem hiding this comment.
That's the bidder object I was trying to completely get rid of in my prebid-server-java PR, about which you had questions and bad feelings. So as I left it untouched in prebid-server-java, here I did the same. So now both go and java repos are in sync. Do you have any recommendations on this?
sejanick
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.