NASA Challenge_[@dirksavage88]_[Implement hardware rendering, (fixes #159)] #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! This seems like it might also be fixing #100? |
EzraBrooks
requested changes
Aug 20, 2024
There was a problem hiding this comment.
These changes all make sense to me, but could you reword your commit title to include a reference to the issue? i.e.
implement hardware rendering (fixes #159)
We are trying to make sure all commits reference an issue, for the sake of NASA's software project management requirements.
dirksavage88
changed the title
dirksavage88
changed the title
|
To clarify, I mean the commit message itself - not the name of the PR. |
Signed-off-by: dirksavage88 <[email protected]>
dirksavage88
force-pushed
the
hardware_rendering
branch
from
e1f835d
to
aa003b8
Compare
Signed-off-by: dirksavage88 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159
With hardware rendering in place, the gazebo models and world can run at a higher RTF and thus open up more possibilities for detailed environments, to include particle emitter (dust and lighting) sources. First screen shot without hardware rendering, second is with hardware rendering using Intel iris xe graphics:
Test of the mesa drivers inside the docker container (basic OpenGL test)
