Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move InnerProductTypes out of base to proof_primitive #232

Open
4 tasks
stuarttimwhite opened this issue Oct 7, 2024 · 3 comments
Open
4 tasks

Move InnerProductTypes out of base to proof_primitive #232

stuarttimwhite opened this issue Oct 7, 2024 · 3 comments
Labels
💎 Bounty refactor Code cleanup or reorganization

Comments

@stuarttimwhite
Copy link
Contributor

stuarttimwhite commented Oct 7, 2024

Background and Motivation

NOTE: #230 should be completed before this ticket can be done. Additionally, be aware that some of the code changes for this issue are likely to conflict with the code changes in the following issue:
#234

Currently, we have reference to 3 types that we want removed from proof-of-sql/src/base:

  1. Curve25519Scalar
  2. RistrettoPoint
  3. InnerProductProof

Any references to these types should be moved to the proof_primitive directory in its own directory named "inner_product". Ultimately, we are trying to remove all cyclic dependencies caused by these types.

Changes Required

Each of these should be a separate PR.

  • Move Curve25519Scalar and its unit tests to new directory proof_primitive/inner_product.
  • Move RistrettoPoint and its unit tests to inner_product.
  • Move InnerProductProof and its unit tests to inner_product.
  • If there is any reference to any of these types remaining (most likely within a test), either move those to inner_product or replace with one of TestScalar, NaiveCommitment, or TestEvaluationProof.
@JayWhite2357 JayWhite2357 added enhancement New feature or request refactor Code cleanup or reorganization good first issue Good for newcomers and removed enhancement New feature or request good first issue Good for newcomers labels Oct 8, 2024
@JayWhite2357
Copy link
Contributor

/bounty $50

Copy link

algora-pbc bot commented Oct 9, 2024

💎 $50 bounty • Space and Time

Steps to solve:

  1. Start working: (Optional) Comment /attempt #232 with your implementation plan. Note: we will only assign an issue if you include an implementation plan with a time estimate. Additionally, to be assigned an issue, you must have previously contributed to the project. You can still work on an issue and submit a PR without being assigned.
  2. Submit work: Create a pull request including /claim #232 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to spaceandtimelabs/sxt-proof-of-sql!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @varshith257 Oct 12, 2024, 8:24:26 AM WIP

@varshith257
Copy link
Contributor

varshith257 commented Oct 12, 2024

/attempt #232

Just waiting the issue #230 to be completed

Algora profile Completed bounties Tech Active attempts Options
@varshith257 15 bounties from 7 projects
Go, Scala,
TypeScript & more
Cancel attempt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 Bounty refactor Code cleanup or reorganization
Projects
None yet
Development

No branches or pull requests

3 participants